Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix submit event from GlobalEventHandlers #18112

Merged
merged 4 commits into from
Jul 10, 2022
Merged

Demix submit event from GlobalEventHandlers #18112

merged 4 commits into from
Jul 10, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the onselect event handler from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16735

@queengooborg queengooborg requested review from a team as code owners July 8, 2022 07:00
@queengooborg queengooborg requested review from wbamberg and removed request for a team July 8, 2022 07:00
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 42

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockchange does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockerror does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onratechange does not exist
    • and 10 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 22 more flaws omitted

URL: /en-US/docs/Web/API/GlobalEventHandlers/oninvalid
Title: GlobalEventHandlers.oninvalid
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLFormElement/onsubmit does not exist

URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub
Flaw count: 28

  • macros:
    • /en-US/docs/Web/API/Window/messageManager does not exist
    • /en-US/docs/Web/API/Window/performance redirects to /en-US/docs/Web/API/performance_property
    • /en-US/docs/Web/API/Window/returnValue does not exist
    • /en-US/docs/Web/API/Window/setResizable does not exist
    • /en-US/docs/Web/API/Window/home does not exist
    • and 19 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/The_message_manager
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs


URL: /en-US/docs/Web/API/GlobalEventHandlers/oninvalid
Title: GlobalEventHandlers.oninvalid
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLFormElement/submit_event
Title: HTMLFormElement: submit event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLFormElement/submit
Title: HTMLFormElement.submit()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Window
Title: Window
on GitHub

(this comment was updated 2022-07-10 00:44:10.922794)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to update.

@teoli2003 teoli2003 merged commit d2b7123 into mdn:main Jul 10, 2022
@queengooborg queengooborg deleted the onsubmit branch July 10, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants