Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "lang" to <html> - part 2 #19890

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Add "lang" to <html> - part 2 #19890

merged 3 commits into from
Aug 23, 2022

Conversation

rubiesonthesky
Copy link
Contributor

Summary

Adding lang attribute to element where it makes sense.

Also fixed some indentation and some other guideline issues in html / js code that I encountered.

Motivation

Based on @teoli2003 's comment on here openwebdocs/project#115 (comment)

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@rubiesonthesky rubiesonthesky requested a review from a team August 23, 2022 20:24
@rubiesonthesky rubiesonthesky requested review from a team as code owners August 23, 2022 20:24
@rubiesonthesky rubiesonthesky requested review from jpmedley, schalkneethling, estelle and Rumyra and removed request for a team August 23, 2022 20:24
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:WebAPI Web API docs labels Aug 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 16 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Element/shadow
Title: <shadow>: The Shadow Root element
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Glossary/insertion_point does not exist
    • /en-US/docs/Web/HTML/Element/element does not exist
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/HTML/Element/content
Title: <content>: The Shadow DOM Content Placeholder element
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Glossary/insertion_point does not exist
    • /en-US/docs/Web/HTML/Element/element does not exist
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/HTML/Element/body
Title: <body>: The Document Body element
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/API/TreeWalker
Title: TreeWalker
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/NodeFilter redirects to /en-US/docs/Web/API/Document/createNodeIterator
    • /en-US/docs/Web/API/NodeFilter redirects to /en-US/docs/Web/API/Document/createNodeIterator

External URLs

URL: /en-US/docs/Web/SVG/Attribute/class
Title: class
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Linking
Title: Linking
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Namespaces_Crash_Course
Title: Namespaces crash course
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/shadow
Title: <shadow>: The Shadow Root element
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/content
Title: <content>: The Shadow DOM Content Placeholder element
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/body
Title: <body>: The Document Body element
on GitHub

No new external URLs

URL: /en-US/docs/Web/Progressive_web_apps/Responsive/Mobile_first
Title: Mobile first
on GitHub

No new external URLs

URL: /en-US/docs/Web/Performance/dns-prefetch
Title: Using dns-prefetch
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/Specificity
Title: Specificity
on GitHub

No new external URLs

URL: /en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/Stacking_context_example_3
Title: Stacking context example 3
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/TreeWalker
Title: TreeWalker
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/ctrlKey
Title: KeyboardEvent.ctrlKey
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/UIEvent/which
Title: UIEvent.which
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Text
Title: Text
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Pointer_events
Title: Pointer events
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MouseEvent/layerX
Title: MouseEvent.layerX
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MouseEvent/layerY
Title: MouseEvent.layerY
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/defaultStatus
Title: Window.defaultStatus
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/toolbar
Title: Window.toolbar
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Window/menubar
Title: Window.menubar
on GitHub

No new external URLs

(this comment was updated 2022-08-23 20:43:17.084590)

@teoli2003 teoli2003 merged commit 82a87de into mdn:main Aug 23, 2022
@rubiesonthesky rubiesonthesky deleted the html-add-lang-attribute-2 branch August 23, 2022 20:49
@Josh-Cena Josh-Cena mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

@schalkneethling schalkneethling Awaiting requested review from schalkneethling schalkneethling is a code owner automatically assigned from mdn/yari-content-html

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubiesonthesky @teoli2003