Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize arguments docs #20277

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Reorganize arguments docs #20277

merged 1 commit into from
Sep 4, 2022

Conversation

Josh-Cena
Copy link
Member

Summary

Motivation

There's some duplicate content on this page, which makes it sound repetitive. Some concepts are also underexplained.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Josh-Cena Josh-Cena requested a review from a team as a code owner September 3, 2022 13:32
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team September 3, 2022 13:32
@github-actions github-actions bot added the Content:JS JavaScript docs label Sep 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Functions/arguments
Title: The arguments object
on GitHub

URL: /en-US/docs/Web/JavaScript/Reference/Functions/arguments/@@iterator
Title: arguments[@@iterator]()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Functions/arguments/length
Title: arguments.length
on GitHub

No new external URLs

(this comment was updated 2022-09-03 13:44:09.237282)

teoli2003
teoli2003 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 2bf6814 into mdn:main Sep 4, 2022
@Josh-Cena Josh-Cena deleted the refactor-arguments branch September 4, 2022 13:39
goshdarnheck pushed a commit to goshdarnheck/content that referenced this pull request Sep 7, 2022
@Josh-Cena @goshdarnheck
Reorganize arguments docs (mdn#20277)
94a0dc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @teoli2003