Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section on checking is regex #20281

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Add a section on checking is regex #20281

merged 2 commits into from
Sep 4, 2022

Conversation

Josh-Cena
Copy link
Member

Summary

Motivation

I intended to document that endsWith() etc. would throw if the parameter is a regex. In doing so I figured that we document in multiple places how the IsRegExp check works. It makes sense to have a dedicated section, similar to #20234.

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Josh-Cena Josh-Cena requested a review from a team as a code owner September 3, 2022 21:53
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team September 3, 2022 21:53
@github-actions github-actions bot added the Content:JS JavaScript docs label Sep 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp
Title: RegExp
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/@@match
Title: RegExp.prototype[@@match]()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/RegExp
Title: RegExp() constructor
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith
Title: String.prototype.startsWith()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith
Title: String.prototype.endsWith()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/matchAll
Title: String.prototype.matchAll()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll
Title: String.prototype.replaceAll()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes
Title: String.prototype.includes()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/match
Title: Symbol.match
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/matchAll
Title: Symbol.matchAll
on GitHub

No new external URLs

(this comment was updated 2022-09-03 23:44:24.902678)

@Josh-Cena Josh-Cena force-pushed the is-regx branch 3 times, most recently from 362917a to efcaf72 Compare September 3, 2022 22:01
@teoli2003 teoli2003 merged commit 3fe8522 into mdn:main Sep 4, 2022
@Josh-Cena Josh-Cena deleted the is-regx branch September 4, 2022 13:38
goshdarnheck pushed a commit to goshdarnheck/content that referenced this pull request Sep 7, 2022
* Add a section on checking is regex

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants