-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section on checking is regex #20281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
362917a
to
efcaf72
Compare
3 tasks
Josh-Cena
commented
Sep 3, 2022
files/en-us/web/javascript/reference/global_objects/regexp/index.md
Outdated
Show resolved
Hide resolved
teoli2003
approved these changes
Sep 4, 2022
goshdarnheck
pushed a commit
to goshdarnheck/content
that referenced
this pull request
Sep 7, 2022
* Add a section on checking is regex * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
I intended to document that
endsWith()
etc. would throw if the parameter is a regex. In doing so I figured that we document in multiple places how theIsRegExp
check works. It makes sense to have a dedicated section, similar to #20234.Supporting details
Related issues
Metadata