Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run prettier on web/g-j #20548

Merged
merged 15 commits into from
Sep 12, 2022
Merged

style: run prettier on web/g-j #20548

merged 15 commits into from
Sep 12, 2022

Conversation

nschonni
Copy link
Contributor

Not run on code fences

@nschonni nschonni requested review from a team as code owners September 11, 2022 06:09
@nschonni nschonni requested review from teoli2003 and schalkneethling and removed request for a team September 11, 2022 06:09
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn Learning area docs labels Sep 11, 2022
@github-actions

This comment was marked as resolved.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few extra fixes, but we are close to land this I think

@teoli2003
Copy link
Contributor

The small need for reformat will be fixed the next time we run Prettier. There will be at least another pass when we deal with code inside fences and before we activate automation. Not necessary very soon, but I would like to avoid this PR to rot.

@teoli2003 teoli2003 merged commit 9b38f88 into mdn:main Sep 12, 2022
@nschonni nschonni deleted the prettier-web-1 branch September 12, 2022 13:36
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
* style: run prettier on web/g-j

* fix: re-escape HTML in alt

* Update files/en-us/web/javascript/reference/global_objects/asyncgeneratorfunction/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/guide/houdini/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/guide/mobile/mobile-friendliness/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/html/attributes/rel/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/html/element/marquee/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/html/element/marquee/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/html/element/thead/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>

* Update files/en-us/web/javascript/reference/global_objects/number/number/index.md

Co-authored-by: Joshua Chen <[email protected]>

* Update files/en-us/web/javascript/reference/global_objects/intl/collator/collator/index.md

* Apply suggestions from code review

Co-authored-by: Jean-Yves Perrier <[email protected]>

* fix: markdownlint issue

* Update files/en-us/web/javascript/reference/global_objects/intl/collator/collator/index.md

Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Joshua Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn Learning area docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants