-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF105 OpenFont COLRv1 behind flag #20637
Conversation
@@ -1065,6 +1065,49 @@ With this feature enabled, Firefox supports [JPEG XL](https://jpeg.org/jpegxl/) | |||
</tbody> | |||
</table> | |||
|
|||
|
|||
#### OpenFont COLRv1 fonts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, not 100% sure this is right place - after all this can be used by APIs or CSS. But this is where the other media information has been put, so copying the pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good question. At the moment it's ordered like this
## APIs
### WebRTC and media
#### OpenFont COLRv1 fonts
What do you think about having it as a sibling of CSS Font Loading API
?
## APIs
### CSS Font Loading API
### OpenFont COLRv1 fonts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would most likely be used by the @font-face rule, so you could argue it should go there too. It probably should go in a media section at top level, along with all the other ones.
Upshot that is no worse than anywhere else and probably just as good or maybe a smidgen better than where I have it. Do you want me to move it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably should go in a media section at top level, along with all the other ones.
Righto
Do you want me to move it?
Nope, all good, thank you 🙌🏻
Preview URLsExternal URLsURL:
(this comment was updated 2022-09-13 09:14:15.470156) |
Taking a look now 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good, please see my comment about the order in the document where we place this section. 👍🏻
Thanks @hamishwillee , merging now 👍🏻 |
* FF105 OpenFont COLRv1 behind flag * Update files/en-us/mozilla/firefox/experimental_features/index.md Co-authored-by: Brian Thomas Smith <[email protected]>
FF104 added support for OpenFont COLRv1 table behidn a flag. This just adds and experiment features note.
Other docs work can be tracked in #20106