Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF105 OpenFont COLRv1 behind flag #20637

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

hamishwillee
Copy link
Collaborator

FF104 added support for OpenFont COLRv1 table behidn a flag. This just adds and experiment features note.

Other docs work can be tracked in #20106

@hamishwillee hamishwillee requested a review from a team as a code owner September 13, 2022 07:06
@hamishwillee hamishwillee requested review from bsmth and removed request for a team September 13, 2022 07:06
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Sep 13, 2022
@@ -1065,6 +1065,49 @@ With this feature enabled, Firefox supports [JPEG XL](https://jpeg.org/jpegxl/)
</tbody>
</table>


#### OpenFont COLRv1 fonts
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, not 100% sure this is right place - after all this can be used by APIs or CSS. But this is where the other media information has been put, so copying the pattern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good question. At the moment it's ordered like this

## APIs
### WebRTC and media
#### OpenFont COLRv1 fonts

What do you think about having it as a sibling of CSS Font Loading API?

## APIs
### CSS Font Loading API
### OpenFont COLRv1 fonts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would most likely be used by the @font-face rule, so you could argue it should go there too. It probably should go in a media section at top level, along with all the other ones.

Upshot that is no worse than anywhere else and probably just as good or maybe a smidgen better than where I have it. Do you want me to move it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should go in a media section at top level, along with all the other ones.

Righto

Do you want me to move it?

Nope, all good, thank you 🙌🏻

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022

Preview URLs

External URLs

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(this comment was updated 2022-09-13 09:14:15.470156)

@bsmth
Copy link
Member

bsmth commented Sep 13, 2022

Taking a look now 👀

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, please see my comment about the order in the document where we place this section. 👍🏻

@bsmth
Copy link
Member

bsmth commented Sep 13, 2022

Thanks @hamishwillee , merging now 👍🏻

@bsmth bsmth merged commit 7235d67 into mdn:main Sep 13, 2022
@hamishwillee hamishwillee deleted the ff104_colv1_expr branch September 16, 2022 00:55
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
* FF105 OpenFont COLRv1 behind flag

* Update files/en-us/mozilla/firefox/experimental_features/index.md

Co-authored-by: Brian Thomas Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants