Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19449 prefers color scheme #20886

Merged
merged 22 commits into from
Oct 13, 2022
Merged

19449 prefers color scheme #20886

merged 22 commits into from
Oct 13, 2022

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Sep 19, 2022

Background:
Embedded SVGs and iframes can now use prefers-color-scheme media query to add styles that inherit (depend on) the color-scheme of the embedding element.

This PR adds details about embedded elements and how media queries can be used to control how embedded elements are styled based on embedding elements. There's an additional example that shows default functionality (browser or OS prefs) and then explicit styling based on the parent (embedding) element.

Other issues and PRs:

@bsmth bsmth requested review from a team as code owners September 19, 2022 09:51
@bsmth bsmth requested review from estelle and removed request for a team September 19, 2022 09:51
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 19, 2022
@bsmth bsmth mentioned this pull request Sep 19, 2022
Closed
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2022 •
edited
Loading

Preview URLs

(this comment was updated 2022-10-13 08:06:12.550723)

@bsmth bsmth requested a review from hamishwillee September 20, 2022 08:50
@hamishwillee
Copy link
Collaborator

I'm away until Monday. @estelle would perhaps be a better person to review CSS.

@bsmth bsmth requested a review from hamishwillee October 6, 2022 09:23
@bsmth bsmth requested a review from estelle October 10, 2022 12:44
estelle
estelle reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback

@bsmth
Copy link
Member Author

bsmth commented Oct 13, 2022

Some more feedback

Thank you, incorporating the comments now.

@bsmth bsmth requested a review from estelle October 13, 2022 08:03
estelle
estelle approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

committed my one grammar change. looks good!

@estelle estelle merged commit b85094c into mdn:main Oct 13, 2022
@bsmth bsmth deleted the 19449-prefers-color-scheme branch October 14, 2022 08:09
@bsmth
Copy link
Member Author

bsmth commented Oct 14, 2022

Thanks, Estelle 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner left review comments

@estelle estelle estelle approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bsmth @hamishwillee @estelle @caugner