Document PerformanceMark constructor #21821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs
(this comment was updated 2022-10-26 11:58:36.072095) |
wbamberg
requested changes
Oct 25, 2022
|
Thanks for the review, Will! I mostly copied the new contstructor page from https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark. So, I applied your feedback to both, the new constructor page and performance.mark(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds docs for the constructor of https://developer.mozilla.org/en-US/docs/Web/API/PerformanceMark.
Motivation
I'm working on openwebdocs/project#62.
Additional details
Wait, why does it have a constructor when there is
performance.mark()? 😱When using the constructor, the mark isn't added to the browser's performance timeline!
Related issues and pull requests
No BCD PR for the
mdn_urlyet. Will file one soon. Promised.