Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to crossOriginIsolated property #23275

Merged
merged 5 commits into from
Jan 2, 2023

Conversation

NiedziolkaMichal
Copy link
Member

This PR adds some more details to crossOriginIsolated property. I have checked the required header values by manual test in Chrome, but they are also listed in the specification. I have found the unlocked features by reading web.dev article and checked MDN existing pages.

@NiedziolkaMichal NiedziolkaMichal requested a review from a team as a code owner December 30, 2022 18:02
@NiedziolkaMichal NiedziolkaMichal requested review from jpmedley and removed request for a team December 30, 2022 18:02
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

Preview URLs

Flaws (3)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Window/postMessage
Title: Window.postMessage()
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer/Planned_changes redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer
Title: SharedArrayBuffer
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

(comment last updated: 2023-01-02 12:50:40)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I have some suggestions.
In the code example it also says "Post SharedArrayBuffer" maybe we want to say something more generic there, too.

@NiedziolkaMichal
Copy link
Member Author

Thank you for the review.
The exact same SharedArrayBuffer example is used in 5 different articles. How about actually using SharedArrayBuffer in there? It could be:

const myWorker = new Worker('worker.js');

if (crossOriginIsolated) {
  const buffer = new SharedArrayBuffer(16);
  myWorker.postMessage(buffer);
} else {
  const buffer = new ArrayBuffer(16);
  myWorker.postMessage(buffer);
}

@Elchi3
Copy link
Member

Elchi3 commented Jan 2, 2023

yeah, that looks like a good idea. Always great to show code that isn't just theory.

@NiedziolkaMichal NiedziolkaMichal requested review from a team as code owners January 2, 2023 12:48
@NiedziolkaMichal NiedziolkaMichal requested review from Elchi3 and removed request for a team January 2, 2023 12:48
@github-actions github-actions bot added Content:HTTP HTTP docs Content:JS JavaScript docs labels Jan 2, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 0d51630 into mdn:main Jan 2, 2023
@NiedziolkaMichal
Copy link
Member Author

Thank you too

ArthurSonzogni added a commit to ArthurSonzogni/mdn-content that referenced this pull request Jan 3, 2023
This PR adds documentation for `Cross-Origin-Embedder-Policy`:
`credentialless` value.

This is part of the HTML specification + FETCH.
It is implemented by:
- Chrome: 96.
- Firefox: Nightly + origin trial.

In a follow-up, I am also going to fix the Iframe.credentialless
documentation, and I need refer to COEP:credentialless.

Chrome status:
- https://chromestatus.com/feature/4918234241302528

Firefox status:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1731778

Past PR about COEP:
- mdn#8871
- mdn#23097
- mdn#23275

Follow-up:
ArthurSonzogni added a commit to ArthurSonzogni/mdn-content that referenced this pull request Jan 3, 2023
This PR adds documentation for `Cross-Origin-Embedder-Policy`:
`credentialless` value.

This is part of the HTML specification + FETCH.
It is implemented by:
- Chrome: 96.
- Firefox: Nightly + origin trial.

In a follow-up, I am also going to fix the Iframe.credentialless
documentation, and I need refer to COEP:credentialless.

Chrome status:
- https://chromestatus.com/feature/4918234241302528

Firefox status:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1731778

Past PR about COEP:
- mdn#8871
- mdn#23097
- mdn#23275
Elchi3 pushed a commit that referenced this pull request Jan 4, 2023
* Document COEP:credentialless

This PR adds documentation for `Cross-Origin-Embedder-Policy`:
`credentialless` value.

This is part of the HTML specification + FETCH.
It is implemented by:
- Chrome: 96.
- Firefox: Nightly + origin trial.

In a follow-up, I am also going to fix the Iframe.credentialless
documentation, and I need refer to COEP:credentialless.

Chrome status:
- https://chromestatus.com/feature/4918234241302528

Firefox status:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1731778

Past PR about COEP:
- #8871
- #23097
- #23275

* Update files/en-us/web/http/headers/cross-origin-embedder-policy/index.md

Co-authored-by: Chris Mills <[email protected]>

* Update files/en-us/web/http/headers/cross-origin-embedder-policy/index.md

Co-authored-by: Chris Mills <[email protected]>

* Address Chris #2 comment.

* Address @Elchi3 suggestions.

Co-authored-by: Chris Mills <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:JS JavaScript docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants