-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more details to crossOriginIsolated
property
#23275
Conversation
Preview URLs
Flaws (3)Note! 3 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
(comment last updated: 2023-01-02 12:50:40) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I have some suggestions.
In the code example it also says "Post SharedArrayBuffer" maybe we want to say something more generic there, too.
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Thank you for the review. const myWorker = new Worker('worker.js');
if (crossOriginIsolated) {
const buffer = new SharedArrayBuffer(16);
myWorker.postMessage(buffer);
} else {
const buffer = new ArrayBuffer(16);
myWorker.postMessage(buffer);
} |
yeah, that looks like a good idea. Always great to show code that isn't just theory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Thank you too |
This PR adds documentation for `Cross-Origin-Embedder-Policy`: `credentialless` value. This is part of the HTML specification + FETCH. It is implemented by: - Chrome: 96. - Firefox: Nightly + origin trial. In a follow-up, I am also going to fix the Iframe.credentialless documentation, and I need refer to COEP:credentialless. Chrome status: - https://chromestatus.com/feature/4918234241302528 Firefox status: - https://bugzilla.mozilla.org/show_bug.cgi?id=1731778 Past PR about COEP: - mdn#8871 - mdn#23097 - mdn#23275 Follow-up:
This PR adds documentation for `Cross-Origin-Embedder-Policy`: `credentialless` value. This is part of the HTML specification + FETCH. It is implemented by: - Chrome: 96. - Firefox: Nightly + origin trial. In a follow-up, I am also going to fix the Iframe.credentialless documentation, and I need refer to COEP:credentialless. Chrome status: - https://chromestatus.com/feature/4918234241302528 Firefox status: - https://bugzilla.mozilla.org/show_bug.cgi?id=1731778 Past PR about COEP: - mdn#8871 - mdn#23097 - mdn#23275
* Document COEP:credentialless This PR adds documentation for `Cross-Origin-Embedder-Policy`: `credentialless` value. This is part of the HTML specification + FETCH. It is implemented by: - Chrome: 96. - Firefox: Nightly + origin trial. In a follow-up, I am also going to fix the Iframe.credentialless documentation, and I need refer to COEP:credentialless. Chrome status: - https://chromestatus.com/feature/4918234241302528 Firefox status: - https://bugzilla.mozilla.org/show_bug.cgi?id=1731778 Past PR about COEP: - #8871 - #23097 - #23275 * Update files/en-us/web/http/headers/cross-origin-embedder-policy/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/web/http/headers/cross-origin-embedder-policy/index.md Co-authored-by: Chris Mills <[email protected]> * Address Chris #2 comment. * Address @Elchi3 suggestions. Co-authored-by: Chris Mills <[email protected]>
This PR adds some more details to crossOriginIsolated property. I have checked the required header values by manual test in Chrome, but they are also listed in the specification. I have found the unlocked features by reading web.dev article and checked MDN existing pages.