Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating content that storage is always partitioned #24250

Merged
merged 63 commits into from
Jun 13, 2023
Merged

Updating content that storage is always partitioned #24250

merged 63 commits into from
Jun 13, 2023

Conversation

HannahPeuckmann
Copy link
Contributor

Description

Updating the outdated documents that deal with Storage Access API/ storage access grants. Storage is always partitioned and storage access grants are limited to access to cookies now.

Motivation

The documentation about the Storage Access API and automatic storage access grants are outdated since the implementation changed in Fx109. The outdated documentation led to confusion because developers expected to see the old behavior.

Additional details

Release notes: https://www.mozilla.org/en-US/firefox/109.0/releasenotes/
Meta bug: Bug 1758737 - [meta] Always Partition Storage

Related issues and pull requests

@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023 •
edited
Loading

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Privacy/State_Partitioning
Title: State Partitioning
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Firefox/Privacy/Storage_access_policy

(comment last updated: 2023-05-22 19:14:18)

Trikolon
Trikolon reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MDN updates! This will make storage access a bit less confusing I hope.
Your patch changes a couple of mentions of storage to "cookies". While I don't think that's strictly required (the spec still talks about storage and cookies being the only "storage" affected by the storage access api), but it might help developers understand better that we only mean cookies.

I can't officially r+ or r- on this repo so just leaving some comments.

files/en-us/web/api/document/requeststorageaccess/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/requeststorageaccess/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/document/requeststorageaccess/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/storage_access_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/privacy/state_partitioning/index.md Outdated Show resolved Hide resolved
files/en-us/web/privacy/storage_access_policy/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Trikolon
Trikolon reviewed Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! I think we can update the PR to request review now.

I'm still not super happy that now there is a bit of a disconnect between the spec talking about storage (cookies being the only storage affected) and the MDN article talking about cookies. Maybe we can discuss this with @bvandersloot-mozilla when he's back.

files/en-us/web/privacy/state_partitioning/index.md Outdated Show resolved Hide resolved
@HannahPeuckmann
Copy link
Contributor Author

Thanks for the great work! I think we can update the PR to request review now.

I'm still not super happy that now there is a bit of a disconnect between the spec talking about storage (cookies being the only storage affected) and the MDN article talking about cookies. Maybe we can discuss this with @bvandersloot-mozilla when he's back.

Yes, let's do so, the opinion from @bvandersloot-mozilla will be valuable!

@HannahPeuckmann HannahPeuckmann marked this pull request as ready for review March 1, 2023 10:06
@HannahPeuckmann HannahPeuckmann requested review from a team as code owners March 1, 2023 10:06
@HannahPeuckmann HannahPeuckmann requested review from Elchi3 and removed request for a team March 1, 2023 10:06
@HannahPeuckmann HannahPeuckmann changed the title WIP: Updating content that storage is always partitioned Updating content that storage is always partitioned Mar 1, 2023
@github-actions github-actions bot added Content:JS JavaScript docs Content:Learn Learning area docs Content:WebExt WebExtensions docs labels May 15, 2023
@github-actions github-actions bot removed Content:WebExt WebExtensions docs Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries Content:Learn Learning area docs Content:HTTP HTTP docs labels May 15, 2023
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label May 16, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@Rumyra Rumyra removed request for a team, jpmedley, teoli2003 and estelle May 16, 2023 09:11
dipikabh
dipikabh approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It's looking good, @HannahPeuckmann, just a few nits.

Also marking my approval here.

files/en-us/web/api/storage_access_api/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/storage_access_api/index.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label May 17, 2023
@HannahPeuckmann HannahPeuckmann requested a review from teoli2003 May 17, 2023 14:26
@dipikabh dipikabh removed the request for review from schalkneethling June 13, 2023 17:06
@dipikabh dipikabh dismissed teoli2003’s stale review June 13, 2023 17:06

requested changes have been addressed

@dipikabh dipikabh merged commit e767e78 into mdn:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trikolon Trikolon Trikolon left review comments

@dipikabh dipikabh dipikabh approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.