-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new display mode How-to page to PWA docs #24709
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2023-03-01 09:38:42) |
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a lot of feedback.
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a good link to add.
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Patrick!
My main suggestion is about framing, and relatedly naming.
Ideally the title, and framing, should reflect the question a developer who's trying to build a PWA might have. (We could think of it like: what would they search StackOverflow for: and maybe even mining SO could help us discover and prioritize how-tos.)
My reservation about "How to/choose a display mode" is that "display mode" is a technical term in PWA-land, so if someone knows that, they probably already know about display
.
If it were me I would call this something like "Create a standalone app" - although there are other things we can do with display
, it seems like standalone
is the one most people will be interested in (and of course browser
is the default, so there's nothing to do for that case).
Anyway, just a suggestion.
I really like this comment. I did look at SO for a little bit and thought about how to phrase this. But in the end, I think "Create a standalone app" is probably the best we can use. Sure, you can do other things with For people learning about PWA as a way to create apps, creating a standalone app is very likely what they will want to learn how to do anyway. |
@estelle @wbamberg not sure why, but it looks like I can only ask one of you to re-review the PR. Anyway, consider yourself both pinged. When you have some time, please take a look, and let me know if and how we should merge this (considering that this is a new page that doesn't yet have a home in our new PWA doc set). |
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
browser-compat: html.manifest.display | ||
--- | ||
|
||
[Progressive Web Apps](/en-US/docs/Web/Progressive_web_apps) (PWAs) that are installed on a user's device can define how they appear when the user launches them. They can choose to be displayed in a web browser like websites, or have their own dedicated windows similar to how native applications work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Progressive Web Apps](/en-US/docs/Web/Progressive_web_apps) (PWAs) that are installed on a user's device can define how they appear when the user launches them. They can choose to be displayed in a web browser like websites, or have their own dedicated windows similar to how native applications work. | |
Settings in the [web application manifest](/en-US/docs/Web/Manifest) can define how the browser renders installed [Progressive Web Apps](/en-US/docs/Web/Progressive_web_apps) (PWAs) when the user launches them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somehow like that my version starts with the term "Progressive Web Apps" and that the thing about the manifest comes after. I think it might be easier for new people to understand it this way.
- PWA, which are apps on people's devices, can appear in several ways.
- This is done via the app's manifest file.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Progressive Web Apps" or "Progressive web apps"? Our existing documentation uses the second. web.dev and learn.microsoft.com use the first, so I suppose we should too. Personally I like the second, but consistency is more important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also as before, "native" or something else? I think we can always use it here and go back and change when we have decided.
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @captainbrosset ! Some of my comments are more like, I wonder what we should do here. Others are more helpful I hope :)
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
browser-compat: html.manifest.display | ||
--- | ||
|
||
[Progressive Web Apps](/en-US/docs/Web/Progressive_web_apps) (PWAs) that are installed on a user's device can define how they appear when the user launches them. They can choose to be displayed in a web browser like websites, or have their own dedicated windows similar to how native applications work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Progressive Web Apps" or "Progressive web apps"? Our existing documentation uses the second. web.dev and learn.microsoft.com use the first, so I suppose we should too. Personally I like the second, but consistency is more important.
browser-compat: html.manifest.display | ||
--- | ||
|
||
[Progressive Web Apps](/en-US/docs/Web/Progressive_web_apps) (PWAs) that are installed on a user's device can define how they appear when the user launches them. They can choose to be displayed in a web browser like websites, or have their own dedicated windows similar to how native applications work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also as before, "native" or something else? I think we can always use it here and go back and change when we have decided.
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/display_mode/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this looks awesome, thank you Patrick!
@estelle , are your comments addressed? |
As discussed yesterday, this is ready for merging. |
Description
This PR is just one step within the larger PWA docs refresh project: mdn/mdn#280
One of the steps we need to do in this larger project is create a new sidebar, which this PR does not do. @wbamberg is working on in mdn/yari#8238.
This PR adds one new How to page to the PWA docs about display mode.
Motivation
In the PWA docs refresh project, we agreed to create a new How to section that will contain 10 to 20 new pages about many of the features that PWAs can use. Display mode is one of them.
Related issues and pull requests
Next step
Once reviewed and approved, the idea is to merge this in a way that doesn't necessarily appears on MDN just yet. Once we have enough of the new content that we think is useful, we will release the new sidebar and/or landing page to link to the new stuff.