Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove documentation of IE-only API features #24794

Merged
merged 7 commits into from
Mar 12, 2023
Merged

Remove documentation of IE-only API features #24794

merged 7 commits into from
Mar 12, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR is a cherry-pick of #18750 to remove the IE-only features for web APIs. These features are long gone from modern browsers and have been removed from BCD.

@queengooborg queengooborg requested review from a team as code owners February 23, 2023 12:45
@queengooborg queengooborg requested review from Elchi3 and removed request for a team February 23, 2023 12:45
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023 •
edited
Loading

Preview URLs (10 pages)
Flaws (61)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PointerEvent
Title: PointerEvent
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PointerEvent/getPredictedEvents does not exist
    • /en-US/docs/Web/API/HTMLElement/pointerrawupdate_event does not exist

URL: /en-US/docs/Web/API/Element/gestureend_event
Title: Element: gestureend event
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/GestureEvent/rotation does not exist
    • /en-US/docs/Web/API/GestureEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/gesturestart_event
Title: Element: gesturestart event
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/GestureEvent/rotation does not exist
    • /en-US/docs/Web/API/GestureEvent/scale does not exist

URL: /en-US/docs/Web/API/Element/gesturechange_event
Title: Element: gesturechange event
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/GestureEvent/rotation does not exist
    • /en-US/docs/Web/API/GestureEvent/scale does not exist

URL: /en-US/docs/Web/API/TouchEvent
Title: TouchEvent
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/TouchEvent/rotation does not exist
    • /en-US/docs/Web/API/TouchEvent/scale does not exist

URL: /en-US/docs/Web/Events
Title: Event reference
Flaw count: 51

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/wheel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationcancel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationend_event
    • Can't resolve /en-US/docs/Web/API/Document/animationiteration_event
    • Can't resolve /en-US/docs/Web/API/Document/animationstart_event
    • and 46 more flaws omitted
External URLs (7)

URL: /en-US/docs/Web/API/PointerEvent
Title: PointerEvent

URL: /en-US/docs/Web/API/Element/gestureend_event
Title: Element: gestureend event

URL: /en-US/docs/Web/API/Element/gesturestart_event
Title: Element: gesturestart event

URL: /en-US/docs/Web/API/Element/gesturechange_event
Title: Element: gesturechange event

URL: /en-US/docs/Web/API/fetch
Title: fetch()

URL: /en-US/docs/Web/API/TouchEvent
Title: TouchEvent

(comment last updated: 2023-03-10 12:36:36)

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg requested a review from a team as a code owner February 25, 2023 00:40
@queengooborg queengooborg requested review from schalkneethling and removed request for a team February 25, 2023 00:40
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs and removed rebase needed 🚧 labels Feb 25, 2023
@queengooborg queengooborg requested a review from estelle February 26, 2023 04:54
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg requested a review from a team as a code owner February 26, 2023 23:37
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs rebase needed 🚧 and removed Content:HTML Hypertext Markup Language docs rebase needed 🚧 labels Feb 26, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added Content:Media Media docs rebase needed 🚧 and removed Content:CSS Cascading Style Sheets docs rebase needed 🚧 labels Feb 28, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg
Copy link
Collaborator Author

This PR keeps on running into merge conflicts -- I'd love to get review on this PR sometime soon!

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs and removed merge conflicts 🚧 [PR only] Content:Media Media docs labels Mar 10, 2023
hamishwillee
hamishwillee approved these changes Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg This was quite complicated to review. I am fairly confident it is good though.

Unlike others (possibly), I'm also very pleased to see these gone.

@hamishwillee hamishwillee merged commit c524015 into mdn:main Mar 12, 2023
@queengooborg queengooborg deleted the ms-extensions-api branch March 13, 2023 00:09
@mdn mdn deleted a comment Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

@schalkneethling schalkneethling Awaiting requested review from schalkneethling schalkneethling was automatically assigned from mdn/yari-content-html

@estelle estelle Awaiting requested review from estelle

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @hamishwillee