-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <(color|hue)-interpolation-method>
; de-duplicate <hue>
descriptions
#26775
Conversation
Preview URLs (10 pages)
Flaws (3)Note! 7 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
External URLs (5)URL:
URL:
(comment last updated: 2023-06-12 14:54:49) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
That's really cool. Maybe it's useful somewhere, you can use conic gradient and a 50% border radius to get something like this without canvas: |
If we need to, we could do inline HTML, but the tables you've added look great without any additional changes, so I wouldn't update them to use HTML anyway. |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Brian Thomas Smith <[email protected]>
Thanks a lot for your patience, @yarusome - I'll take a final look over it today, I think we're nearly there 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done on this addition and cleanup! 🎉 I've two comments outstanding, but I think we're ready to merge when they're addressed.
Leaving a +1 in advance 👍🏻
@bsmth The two comments have been addressed. Thanks for your time on doing such a large review 🙏 |
Description
This PR adds the CSS data types
<color-interpolation-method>
and<hue-interpolation-method>
, and removes duplicate<hue>
descriptions on CSS color functions.Motivation
Additional details
W3C issue related to hue interpolation: w3c/csswg-drafts#8838.
Related issues and pull requests
Fixes #26435.