Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <(color|hue)-interpolation-method>; de-duplicate <hue> descriptions #26775

Merged
merged 65 commits into from
Jun 12, 2023

Conversation

yarusome
Copy link
Contributor

Description

This PR adds the CSS data types<color-interpolation-method> and <hue-interpolation-method>, and removes duplicate <hue> descriptions on CSS color functions.

Motivation

Additional details

W3C issue related to hue interpolation: w3c/csswg-drafts#8838.

Related issues and pull requests

Fixes #26435.

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label May 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

Preview URLs (10 pages)
Flaws (3)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/color_value
Title: <color>
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/blog/css-color-module-level-4/

URL: /en-US/docs/Web/CSS/hue-interpolation-method
Title: <hue-interpolation-method>
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/linear-gradient() redirects to /en-US/docs/Web/CSS/gradient/linear-gradient

URL: /en-US/docs/Web/CSS/hue
Title: <hue>
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.types.hue
External URLs (5)

URL: /en-US/docs/Web/CSS/color_value
Title: <color>


URL: /en-US/docs/Web/CSS/hue
Title: <hue>

(comment last updated: 2023-06-12 14:54:49)

@yarusome

This comment was marked as outdated.

@yarusome

This comment was marked as outdated.

@yarusome

This comment was marked as outdated.

@bsmth
Copy link
Member

bsmth commented May 19, 2023

I spent some time constructing a could-be-improved live demo of color wheels:

That's really cool. Maybe it's useful somewhere, you can use conic gradient and a 50% border radius to get something like this without canvas:

https://codepen.io/bsmth/pen/RweVNMW

@bsmth
Copy link
Member

bsmth commented May 19, 2023

It seems that GFM doesn't provide a syntax to center table heads

If we need to, we could do inline HTML, but the tables you've added look great without any additional changes, so I wouldn't update them to use HTML anyway.

@yarusome

This comment was marked as resolved.

@yarusome yarusome requested a review from bsmth June 3, 2023 15:43
@bsmth
Copy link
Member

bsmth commented Jun 8, 2023

Thanks a lot for your patience, @yarusome - I'll take a final look over it today, I think we're nearly there 👍🏻

@estelle estelle removed their request for review June 9, 2023 19:15
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on this addition and cleanup! 🎉 I've two comments outstanding, but I think we're ready to merge when they're addressed.

Leaving a +1 in advance 👍🏻

@yarusome
Copy link
Contributor Author

@bsmth The two comments have been addressed. Thanks for your time on doing such a large review 🙏

@bsmth bsmth merged commit c754ecf into mdn:main Jun 12, 2023
@yarusome yarusome deleted the color-method branch June 12, 2023 15:00
@bsmth bsmth mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundancy in the descriptions of various hue-related CSS color functions
3 participants