Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explanation of font-variant-alternates versus font-feature-set… #27306

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

wbamberg
Copy link
Collaborator

This is yet another attempt to improve https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant-alternates.

See #27206 (comment) etc.

This PR:

  • removes the redundant font-feature-settings: "swsh" 1;
  • explains a bit about how this property works alongside @font-feature-values and how it relates to font-feature-settings, and what the example is doing
  • add some links to See also

@drott , if you would like to check this for accuracy I would appreciate it!

@wbamberg wbamberg requested a review from a team as a code owner June 13, 2023 17:36
@wbamberg wbamberg requested review from estelle and removed request for a team June 13, 2023 17:36
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jun 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/font-variant-alternates
Title: font-variant-alternates

(comment last updated: 2023-06-14 00:58:23)

@drott
Copy link

drott commented Jun 13, 2023

Thanks, yes, this works well.

@estelle estelle merged commit 802eea0 into mdn:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants