fix: image is not readable in dark theme #29841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujshandillya
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:Learn
|
Hey @hamishwillee, can you please review the PR and merge if there are no issues. Thanks✌️ |
Josh-Cena
reviewed
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Images were not readable in dark theme, so changed the background color to white.
Motivation
The png images on the website are unreadable in dark theme. So I changed their background colour to white which makes them much more readable.
Additional details
Before, it was unreadable in dark mode, screenshot for reference:
Now the image is readable.
Related issues and pull requests
Relates to #29840