update and fix to Cookie Store API #30183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyclouds2001
commented
Nov 26, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
skyclouds2001
commented
Nov 28, 2023
skyclouds2001
requested review from
wbamberg and
dipikabh
and removed request for
a team
|
see mdn/browser-compat-data#18591, need we add |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make huge change to Cookie Store API related pages
Description
API summary and GroupDataaddwindow.cookieStoreServiceWorkerGlobalScope.cookieStoreServiceWorkerGlobalScope.cookiechangeServiceWorkerRegistration.cookiesto the API group data, also add them to api summary pagefix the incorrect event type in the Cookie Store API - Interfaces section - ExtendableCookieChangeEvent, which should fired atServiceWorkerGlobalScope.cookiechangeevent, notchangeeventadd {{Experimental_Inline}} to Cookie Store API interfaces in API summaryspecificspec-urlsfront matter key of Cookie Store API api summary, see #30542also updatebrowser-compatfront matter key by adding interfaces of this APIadd {{AvailableInWorkers}} [available both in Window and ServiceWorker]CookieChangeEventandExtendableCookieChangeEventaddpartitionedparameter inCookieChangeEventandExtendableCookieChangeEventproperties values descriptionadd a Instance methods section forCookieChangeEventandExtendableCookieChangeEventadd {{Optional_Inline}} macros toCookieChangeEventandExtendableCookieChangeEventconstructoroptionsparameteradd {{AvailableInWorkers}} toExtendableCookieChangeEventinterface [available only in ServiceWorker]CookieStoreadd a Event type section toCookieStore.changeeventadd {{optional_inline}} toCookieStore.get()CookieStore.getAll()CookieStore.delete(), as they are able to accept two types of parametersupdateCookieStore.get()andCookieStore.set()parameters section by adding default value descriptionupdateCookieStore.get()CookieStore.getAll()CookieStore.delete()exception sectionfix the example inCookieStore.get(), which return a Promise, and to get value must useawaitfix the example inCookieStore.getAll(), which return a Promise resolves to an array, and to check if it is empty, we must check thelengthproperty of arrayfix the parameters bug inCookieStore.delete(), that theoptionsparameter can not accept aurlparameter but should acceptdomainparameteradd {{AvailableInWorkers}} (Except forCookieStore.changeevent, which is only available in Window context) [available both in Window and ServiceWorker]CookieStoreManagerfix the incorrect apiref usage inCookieStoreManagerpagesadd {{AvailableInWorkers}}add {{AvailableInWorkers}} [available both in Window and ServiceWorker]total
initial documentation forwindow.cookieStoreServiceWorkerGlobalScope.cookieStoreServiceWorkerGlobalScope.cookiechangeServiceWorkerRegistration.cookiesmake some style update and fixMotivation
Additional details
reference to https://developer.mozilla.org/en-US/docs/Web/API/Cookie_Store_API
reference to https://wicg.github.io/cookie-store/
Related issues and pull requests
Relates to #29975 and #29461