Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with BCD v5.5.6 #31694

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Synchronize with BCD v5.5.6 #31694

merged 1 commit into from
Jan 13, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from a team as code owners January 13, 2024 00:34
@OnkarRuikar OnkarRuikar requested review from sideshowbarker and chrisdavidmills and removed request for a team January 13, 2024 00:34
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs labels Jan 13, 2024
Copy link
Contributor

Preview URLs (11 pages)
Flaws (13)

Note! 9 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLMediaElement
Title: HTMLMediaElement
Flaw count: 12

  • macros:
    • /en-US/docs/Web/API/HTMLMediaElement/played does not exist
    • /en-US/docs/Web/API/HTMLMediaElement/preload does not exist
    • /en-US/docs/Web/API/HTMLMediaElement/seeking does not exist
    • /en-US/docs/Web/API/MediaController does not exist
    • /en-US/docs/Web/API/MediaController does not exist
    • and 7 more flaws omitted

URL: /en-US/docs/Web/CSS/ray
Title: ray()
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 92eab76 into mdn:main Jan 13, 2024
6 checks passed
@OnkarRuikar OnkarRuikar deleted the sync_bcd branch January 13, 2024 07:41
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@dipikabh
Copy link
Contributor

Hi @OnkarRuikar, I am surprised to see the update to the css/ray file here, especially because the same changes were merged via #31514 on Jan 10, just a couple of days before #31694, merged Jan 13.

Could it be because some automated BCD process did not pick up the latest content files?

cc @teoli2003

@OnkarRuikar
Copy link
Contributor Author

Could it be because some automated BCD process did not pick up the latest content files?

This is because content PR got merged before BCD PR went live.

  • On 10th BCDv5.5.5 went live
  • On 11th your PRs go merged, then the bot synced BCDv5.5.5 with content at midnight reverting content changes.
  • On 12th BCDv5.5.6 went live with the BCD PR.
  • On 13th at midnight the bot synced v5.5.6 auto correcting the status.

The issue was your content change got merged(11th) before BCD PR went live in v5.5.6(12th).

@dipikabh
Copy link
Contributor

Thanks for the breakdown of events, @OnkarRuikar.

On 11th your PRs go merged, then the bot synced BCDv5.5.5 with content at midnight reverting content changes.
On 13th at midnight the bot synced v5.5.6 auto correcting the status.

Ideally the bot should not have reverted the content updates. But if that's going to be the case, maybe we (especially those of us who update content for Firefox releases and assess an overall standing of the feature across browsers) should stop making the changes in mdn/content that are going to get sync'ed with a BCD release anyway (changes involving the banner macros and status field in front matter). I'll let the team know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants