Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(css): FF126 - Support for shape() function #33446

Merged
merged 35 commits into from
May 27, 2024
Merged

docs(css): FF126 - Support for shape() function #33446

merged 35 commits into from
May 27, 2024

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented May 6, 2024 •
edited
Loading

🎯 Target release date

📆 May 14, 2024

Description

Firefox 126 adds support for a new function in the <basic-shape> data type: shape().

The support is currently available behind the preference layout.css.basic-shape-shape.enabled, which is enabled by default in Nightly.

Specification: https://drafts.csswg.org/css-shapes-2/#shape-function

Firefox bugs:

Notes for reviewers

  1. You can start your review with this new page: /en-us/Web/CSS/basic-shape/shape
    • The "Specifications" and "Browser compatibility" sections are yet to be updated, so they will show as broken at the moment.
  2. Next page that can be reviewed: /en-us/Web/CSS/basic-shape
  3. /en-US/docs/Web/CSS/clip-path and /en-US/docs/Web/CSS/offset-path have been updated to add a reference to the shape() function.
  4. /en-us/Web/CSS/basic-shape/circle: Added info about the circle function
  5. /en-us/Web/CSS/path: Minor update in syntax formatting
  6. /en-us/Web/SVG/Attribute/d: Added anchor links to the command sections to aid in navigation and updated few headings for consistency

Additional details

Coming soon:

  • PR to update BCD
  • PR to add Firefox release note

Related issues and pull requests

Doc issue tracker: #33081

@dipikabh dipikabh requested review from a team as code owners May 6, 2024 18:02
@dipikabh dipikabh requested review from estelle and hamishwillee and removed request for a team May 6, 2024 18:02
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited
Loading

Preview URLs (10 pages)
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/97
Title: Firefox 97 for developers

(comment last updated: 2024-05-27 14:10:53)

@dipikabh dipikabh mentioned this pull request May 6, 2024
Merged
@dipikabh
Copy link
Contributor Author

dipikabh commented May 6, 2024

The CSSRef macro flaws showing up in this PR are similar to the FirefixSidebar macro flaws in #33450 (comment), but at least the "Check URL issues" test is passing in other PR.

@hamishwillee
Copy link
Collaborator

@dipikabh I'm unmarking myself as reviewer, because @estelle has far more background. If you need me to though, then please add me back.

@hamishwillee hamishwillee removed their request for review May 6, 2024 21:52
@dipikabh dipikabh mentioned this pull request May 6, 2024
Merged
@dipikabh dipikabh mentioned this pull request May 7, 2024
Closed
7 tasks
estelle

This comment was marked as resolved.

Sign in to view

@dipikabh
Copy link
Contributor Author

dipikabh commented May 9, 2024

I've added the following note to the <basic-shape>, path(), and shape() pages:

Note: <fill-rule> is not supported in the {{cssxref("offset-path")}} property.

path() and shape() can both be used with clip-path and offset-path properties, so it is important to let folks know that fill-rule works (currently) only with the clip-path property.

@dipikabh @github-actions
Apply suggestions from linter
bd9dfdc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dipikabh
Copy link
Contributor Author

Hi @estelle, thanks again for the great feedback. I've taken care of all your comments except for explaining quadratic and smooth curves. I think we're close to landing this.

@dipikabh dipikabh requested a review from estelle May 14, 2024 17:35
@dipikabh
Copy link
Contributor Author

Hi @estelle, could I get an approval on this PR? If there's any outstanding feedback, I can address them via a new issue/PR. Thank you!

@estelle
Copy link
Member

estelle commented May 16, 2024

Hi @estelle, could I get an approval on this PR? If there's any outstanding feedback, I can address them via a new issue/PR. Thank you!

I already created three new MDN/content/issues to address issues that don't need to be addressed to merge this PR.

The re-review of this PR is on my todo list.

estelle
estelle reviewed May 17, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of shape() function page

dipikabh
dipikabh commented May 17, 2024
View reviewed changes
@dipikabh dipikabh requested a review from estelle May 17, 2024 15:50
@dipikabh
Copy link
Contributor Author

Hi @estelle, let me know if you have any more feedback for the shape() page. If not, could I get an approval on this PR? Thank you!

OnkarRuikar
OnkarRuikar reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@OnkarRuikar OnkarRuikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the cool animation demos I couldn't help myself.

estelle
estelle reviewed May 23, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still working on it.

@dipikabh
Copy link
Contributor Author

Hi @estelle, I see more comments on the basic-shape page when the focus of this PR is to document the shape() function. I would appreciate it if you could limit your feedback to the shape() function in this PR. I'll take up your review comments on the basic-shape page in a separate PR.

still working on it.

Let me know when you've completed the review of the shape() function page so that I can address all comments in one go.

estelle
estelle reviewed May 26, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed shape

@estelle estelle mentioned this pull request May 27, 2024
Merged
@dipikabh dipikabh dismissed estelle’s stale review May 27, 2024 14:21

I'll address the review comments in a new PR

@dipikabh
Copy link
Contributor Author

Hi @estelle, thanks for your thorough review, I appreciate it.

I've accepted some of your suggestions from the last set, but I'll have to address the remaining feedback and comments in a new PR. I've been delayed in delivering the shape() page as part of the Firefox release.

To allow this one to land, I'll need to ask somebody else from the content team for approval. I'm happy to work on further iterations on the page in a follow-up PR.

@dipikabh dipikabh requested a review from pepelsbey May 27, 2024 14:24
pepelsbey
pepelsbey approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work!

Let’s merge this one first and then continue improving it if needed.

@dipikabh dipikabh merged commit 8cd0816 into mdn:main May 27, 2024
9 checks passed
@dipikabh
Copy link
Contributor Author

@estelle, fyi - I'm working on a new PR to address your other comments. Will link to this PR soon.

@dipikabh dipikabh deleted the css-shape-function branch May 27, 2024 23:21
@dipikabh dipikabh mentioned this pull request May 28, 2024
Merged
wbamberg added a commit to wbamberg/content that referenced this pull request May 28, 2024
@wbamberg
Merge remote-tracking branch 'upstream/main' into add-credential-types
76b6267 
* upstream/main: (55 commits)
  Replace `.` with `#` in example given selectors are `#ids` (mdn#33791)
  update info in cross browser testing strategies (mdn#33730)
  Clarify that `navigator.storage.persist()` depends on heuristics (mdn#33780)
  fix typo (mdn#33785)
  feat: improvements on Glossary/Hoisting (mdn#33787)
  CSS update: overview of shapes guide (mdn#33771)
  CSS update: Shapes from box values (mdn#33770)
  Fix issue 033506: correct droppedEntriesCount (mdn#33538)
  Revert "=== Symbol("foo")" (mdn#33782)
  docs(css): FF126 - Support for `shape()` function (mdn#33446)
  Bump lint-staged from 15.2.4 to 15.2.5 (mdn#33777)
  Bump ajv from 8.13.0 to 8.14.0 (mdn#33776)
  Add missing spaces for `subtlecrypto` (mdn#33774)
  fix: typo in `color_and_luminca` (mdn#33775)
  feat: improvments on gutters (mdn#33751)
  FF127Relnote- data: and javascript: URLS forbidden in base HREF (mdn#33738)
  update the content of SVG `<view>` element (mdn#33710)
  Clipboard.write() - log and fixes (mdn#33769)
  updated ClipboardItem and Clipboard documentation and examples using … (mdn#33262)
  Fix error in the code snippet for Symbol (mdn#33765)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@OnkarRuikar OnkarRuikar OnkarRuikar left review comments

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dipikabh @hamishwillee @estelle @OnkarRuikar @bsmth @pepelsbey