Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken external links #35346

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Fix broken external links #35346

merged 4 commits into from
Aug 7, 2024

Conversation

Josh-Cena
Copy link
Member

This PR fixes all external links that are 403, 404, or generate a TLS error, by either downgrading to HTTP, removing the link, or replacing with a working version.

@Josh-Cena Josh-Cena requested review from a team as code owners August 7, 2024 02:32
@Josh-Cena Josh-Cena requested review from wbamberg, hamishwillee, chrisdavidmills and scottaohara and removed request for a team August 7, 2024 02:32
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:HTTP HTTP docs Content:Accessibility Accessibility docs Content:Media Media docs Content:Learn:Express Learning area Express docs Content:Glossary Glossary entries Content:WebDriver WebDriver docs Content:Games Games docs Content:Security Security docs labels Aug 7, 2024
@github-actions github-actions bot added Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Meta Content in the meta docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:Forms Learning area Forms docs Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs size/m [PR only] 51-500 LoC changed labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Preview URLs (30 pages)
Flaws (38)

Note! 28 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Fenced_frame_API
Title: Fenced Frame API
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Navigator/runAdAuction does not exist

URL: /en-US/docs/Web/WebDriver/Errors
Title: WebDriver errors
Flaw count: 37

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Response
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Clients
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/ElementClickIntercepted
    • and 32 more flaws omitted
External URLs (186)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
Title: globalThis

URL: /en-US/docs/Web/API/WebVR_API
Title: WebVR API

URL: /en-US/docs/Web/API/Attribution_Reporting_API
Title: Attribution Reporting API

URL: /en-US/docs/Web/API/Fenced_frame_API
Title: Fenced Frame API

URL: /en-US/docs/Web/Security/Subresource_Integrity
Title: Subresource Integrity

URL: /en-US/docs/Web/WebDriver/Errors
Title: WebDriver errors

URL: /en-US/docs/Web/CSS/overflow-anchor/Guide_to_scroll_anchoring
Title: Guide to scroll anchoring

URL: /en-US/docs/Web/CSS/@font-palette-values/override-colors
Title: override-colors

URL: /en-US/docs/Web/Accessibility/Seizure_disorders
Title: Web accessibility for seizures and physical reactions

URL: /en-US/docs/Web/Media/Audio_and_video_delivery
Title: Audio and Video Delivery

URL: /en-US/docs/Web/Media/Formats/Video_codecs
Title: Web video codec guide

URL: /en-US/docs/Web/HTML/Global_attributes/spellcheck
Title: spellcheck

URL: /en-US/docs/Web/HTML/Element/link
Title: <link>: The External Resource Link element

URL: /en-US/docs/Web/HTTP/Headers/User-Agent/Firefox
Title: Firefox user agent string reference

URL: /en-US/docs/Related/IMSC
Title: IMSC: subtitles and captioning for the Web

URL: /en-US/docs/Related/IMSC/IMSC_and_other_standards
Title: IMSC and other standards

URL: /en-US/docs/Games/Techniques/Control_mechanisms/Other
Title: Unconventional controls

URL: /en-US/docs/MDN/Writing_guidelines/Writing_style_guide
Title: Writing style guide

URL: /en-US/docs/Glossary/Algorithm
Title: Algorithm

URL: /en-US/docs/Learn/Forms/How_to_build_custom_form_controls
Title: How to build custom form controls

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/mongoose
Title: Express Tutorial Part 3: Using a Database (with Mongoose)

URL: /en-US/docs/Learn/Server-side/Express_Nodejs/deployment
Title: Express Tutorial Part 7: Deploying to production

URL: /en-US/docs/Learn/Server-side/First_steps/Web_frameworks
Title: Server-side web frameworks

URL: /en-US/docs/Learn/Accessibility/WAI-ARIA_basics
Title: WAI-ARIA basics

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
Title: Getting started with Ember

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_deployment_next
Title: Deployment and next steps

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment
Title: Setting up your own test automation environment

URL: /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility
Title: Handling common accessibility problems

(comment last updated: 2024-08-07 21:53:31)

@Josh-Cena Josh-Cena requested a review from wbamberg August 7, 2024 18:37
@Josh-Cena
Copy link
Member Author

I really hope there's a way to automatically discover hijacked sites 😅

wbamberg
wbamberg approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @Josh-Cena !

@wbamberg wbamberg merged commit 7ab2f95 into mdn:main Aug 7, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-broken-link branch August 7, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@wbamberg wbamberg wbamberg approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-http

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

@scottaohara scottaohara Awaiting requested review from scottaohara scottaohara is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Games Games docs Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:Client-side Content under “Client-side JavaScript frameworks” (Svelte, React, Angular, Vue) and related subtrees Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs Content:Learn:Express Learning area Express docs Content:Learn:Forms Learning area Forms docs Content:Learn Learning area docs Content:Media Media docs Content:Meta Content in the meta docs Content:Other Any docs not covered by another "Content:" label Content:Security Security docs Content:WebAPI Web API docs Content:WebDriver WebDriver docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @wbamberg