-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): replace images w/ shared-assets #37643
Conversation
Preview URLs Flaws (1)URL:
(comment last updated: 2025-01-24 12:03:14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better, thanks. Two comments about alt text to look at, but +1 and fine to merge when you're ready
Hi @Jxck. Thanks for the PR. You may find https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/alt helpful. |
I'm going to apply and merge to get these changes in! Thank you |
Description
replace png images in caching section w/ shared-assets svg
Related issues and pull requests
Depends on: