Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): replace images w/ shared-assets #37643

Merged
merged 4 commits into from
Jan 24, 2025
Merged

chore(http): replace images w/ shared-assets #37643

merged 4 commits into from
Jan 24, 2025

Conversation

Jxck
Copy link
Contributor

@Jxck Jxck commented Jan 14, 2025

Description

replace png images in caching section w/ shared-assets svg

Related issues and pull requests

Depends on:

Sorry, something went wrong.

@Jxck Jxck requested a review from a team as a code owner January 14, 2025 09:48
@Jxck Jxck requested review from hamishwillee and removed request for a team January 14, 2025 09:48
@github-actions github-actions bot added Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed labels Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/HTTP/Caching
Title: HTTP caching
Flaw count: 1

  • unknown:
    • No generic content config found

(comment last updated: 2025-01-24 12:03:14)

@bsmth bsmth self-requested a review January 14, 2025 09:51
@bsmth bsmth changed the title replace images w/ shared-assets chore(http): replace images w/ shared-assets Jan 15, 2025
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, thanks. Two comments about alt text to look at, but +1 and fine to merge when you're ready

@bsmth bsmth removed the request for review from hamishwillee January 15, 2025 10:15
@estelle
Copy link
Member

estelle commented Jan 15, 2025

Hi @Jxck. Thanks for the PR. You may find https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/alt helpful.

@bsmth
Copy link
Member

bsmth commented Jan 24, 2025

I'm going to apply and merge to get these changes in! Thank you

bsmth added 2 commits January 24, 2025 11:34
@bsmth bsmth merged commit f3e6411 into mdn:main Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants