Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntaxes to avoid BNF notation (Boolean, Function, Generator) #4553

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 28, 2021

@Elchi3 Elchi3 requested a review from a team as a code owner April 28, 2021 13:02
@Elchi3 Elchi3 requested review from wbamberg and removed request for a team April 28, 2021 13:02
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2021

Preview URLs

Flaws

Note! 13 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind
Title: Function.prototype.bind()
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype does not exist

URL: /en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters
Title: Default parameters
on GitHub
Flaw count: 1

  • broken_links:
    • http:// external links are not allowed (will be forced to https:// at build-time)

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/GeneratorFunction
Title: GeneratorFunction
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean/toString
Title: Boolean.prototype.toString()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean/valueOf
Title: Boolean.prototype.valueOf()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean/toSource
Title: Boolean.prototype.toSource()
on GitHub

No external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind
Title: Function.prototype.bind()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/toString
Title: Function.prototype.toString()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply
Title: Function.prototype.apply()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/call
Title: Function.prototype.call()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/toSource
Title: Function.prototype.toSource()
on GitHub

No external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/Function
Title: Function() constructor
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator/return
Title: Generator.prototype.return()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator/next
Title: Generator.prototype.next()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator/throw
Title: Generator.prototype.throw()
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Classes/constructor
Title: constructor
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters
Title: Default parameters
on GitHub

(this comment was updated 2021-04-29 07:09:37.830559)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great.

@wbamberg wbamberg merged commit ef2ccc8 into mdn:main Apr 30, 2021
@Elchi3 Elchi3 deleted the update-syntaxes branch April 30, 2021 06:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants