Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Constrain[Boolean/DOMString/ULong] and [Double/ULong]Range #7319

Merged
merged 7 commits into from
Jul 27, 2021
Merged

Remove Constrain[Boolean/DOMString/ULong] and [Double/ULong]Range #7319

merged 7 commits into from
Jul 27, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR fixes #5975 by removing the remaining constraint and range typedefs from the MDN web docs. In this PR, the pages for ConstrainBoolean, ConstrainDOMString, and ConstrainULong by moving their content to MediaTrackConstraints and adding redirects + updated links. For the DoubleRange and ULongRange, there are no pages that link to it other than the related constraints, so they were removed entirely/

This PR also updates the wording for ConstrainDouble a slight amount to retain consistency with the other constraints.

@queengooborg queengooborg requested review from a team as code owners July 27, 2021 04:53
@queengooborg queengooborg requested review from Rumyra and removed request for a team July 27, 2021 04:53
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/Screen_Capture_API
Title: Screen Capture API
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/InputDeviceInfo/getCapabilities
Title: InputDeviceInfo.getCapabilities()
on GitHub
Flaw count: 15

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 10 more flaws omitted

URL: /en-US/docs/Web/API/MediaTrackConstraints
Title: MediaTrackConstraints
on GitHub
Flaw count: 32

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 23 more flaws omitted
  • sectioning:
    • Excess <h2> tag that is NOT at root-level (id='Specifications', text='Specifications')
    • Excess <h2> tag that is NOT at root-level (id='Browser_compatibility', text='Browser compatibility')
    • Excess <h2> tag that is NOT at root-level (id='See_also', text='See also')
    • 2 'div.bc-data' or 'div.bc-specs' elements found but deeply nested.

URL: /en-US/docs/Web/API/MediaTrackConstraints/width
Title: MediaTrackConstraints.width
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/sampleRate
Title: MediaTrackConstraints.sampleRate
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/height
Title: MediaTrackConstraints.height
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/groupId
Title: MediaTrackConstraints.groupId
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/noiseSuppression
Title: MediaTrackConstraints.noiseSuppression
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/echoCancellation
Title: MediaTrackConstraints.echoCancellation
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/cursor
Title: MediaTrackConstraints.cursor
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/channelCount
Title: MediaTrackConstraints.channelCount
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/facingMode
Title: MediaTrackConstraints.facingMode
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/sampleSize
Title: MediaTrackConstraints.sampleSize
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/autoGainControl
Title: MediaTrackConstraints.autoGainControl
on GitHub
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/logicalSurface
Title: MediaTrackConstraints.logicalSurface
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/deviceId
Title: MediaTrackConstraints.deviceId
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

URL: /en-US/docs/Web/API/MediaTrackConstraints/displaySurface
Title: MediaTrackConstraints.displaySurface
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase

External URLs

URL: /en-US/docs/Web/API/Screen_Capture_API
Title: Screen Capture API
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/InputDeviceInfo/getCapabilities
Title: InputDeviceInfo.getCapabilities()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints
Title: MediaTrackConstraints
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/width
Title: MediaTrackConstraints.width
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/sampleRate
Title: MediaTrackConstraints.sampleRate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/height
Title: MediaTrackConstraints.height
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/groupId
Title: MediaTrackConstraints.groupId
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/noiseSuppression
Title: MediaTrackConstraints.noiseSuppression
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/echoCancellation
Title: MediaTrackConstraints.echoCancellation
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/cursor
Title: MediaTrackConstraints.cursor
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/channelCount
Title: MediaTrackConstraints.channelCount
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/facingMode
Title: MediaTrackConstraints.facingMode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/sampleSize
Title: MediaTrackConstraints.sampleSize
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/autoGainControl
Title: MediaTrackConstraints.autoGainControl
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/logicalSurface
Title: MediaTrackConstraints.logicalSurface
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/deviceId
Title: MediaTrackConstraints.deviceId
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/MediaTrackConstraints/displaySurface
Title: MediaTrackConstraints.displaySurface
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 4d2a2f3 into mdn:main Jul 27, 2021
@queengooborg queengooborg deleted the constraints-removal branch July 27, 2021 09:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Constrain{Double, Boolean, DOMString, ULong} and {ULong, Double}Range
2 participants
@queengooborg @sideshowbarker