Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pagemacro inclusion of image guide in HTML>Element>img #7996

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

hamishwillee
Copy link
Collaborator

This removes the pagemacro inclusion of the Image guide and reference into HTML > Element > img topic on "supported image types". It further removes tidies up the image guide links to fix up some notes and links. This is part of #3196

The change essentially just creates a smaller list and link to the relevant information.

It is also precursor to work I am going to do for #7744

@hamishwillee hamishwillee requested review from a team as code owners August 17, 2021 04:13
@hamishwillee hamishwillee requested review from Rumyra and removed request for a team August 17, 2021 04:13
</ul>


<p>The newer formats like <a href="/en-US/docs/Web/Media/Formats/Image_types#webp">WebP</a> and <a href="/en-US/docs/Web/Media/Formats/Image_types#avif">AVIF</a> are highly recommended as they are now broadly (and somewhat deeply) supported by web browsers, and perform much better than PNG, JPEG, GIF for both still and animated images. SVG remains the recommended format for images that that must be drawn accurately at different sizes.</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my only concern about the edit. IMO webp is now the format of choice unless you need to use SVG - it has broad support, and in terms of market share is "more than deep enough". That is not quite so true of AVIF. Anyway, decided it was time to start pushing the newer formats.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/Media/Formats/Image_types
Title: Image file type and format guide
on GitHub


URL: /en-US/docs/Web/HTML/Element/img
Title: <img>: The Image Embed element
on GitHub

No new external URLs

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. But approving already.

files/en-us/web/html/element/img/index.html Outdated Show resolved Hide resolved
@hamishwillee hamishwillee merged commit f8eb89b into mdn:main Aug 17, 2021
@hamishwillee hamishwillee deleted the pagemacro_images branch August 17, 2021 07:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants