Update JS async module for rewrite in content PR 12930 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd remove them since they probably rot when no one pays attention to them anymore from any MDN page. |
Elchi3
approved these changes
Mar 7, 2022
Yeah, fair enough. Removed in 0f4609d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the learning-area counterpart to mdn/content#12930. Marking as a draft because this should be merged along with mdn/content#12930, and changes in either PR might mean we need changes in the other one. So let's not merge this until mdn/content#12930 is approved (and vice versa).
It adds example code for the new workers article and for a promises assessment. I've deleted most of the other ones, since the articles don't use them any more. I decided to keep the setTimeout/setInterval/requestAnimationFrame ones, in case we decide to relocate this content. But perhaps I should delete them too? We could always get them out of Git history.