fix(npm): use import
to dynamically load esm modules
#130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@mdn/rari
cannot be installed with Node.js v22.12+, as it usingrequire()
in .js files with"type": "module"
inpackage.json
, which is currently incompatible with Node.js v22.12.0 due to stricter module handling. See: nodejs/node#56155.Use
import
to dynamically load esm modules, as we have already use this in the current file:rari/rari-npm/lib/download.js
Line 68 in 0327040
Motivation
I cannot successfully run
yarn install
inmdn/content
with Node.js v22.13 installed.Additional details
I've run
npm install && npm run export-schema && npm run generate-types && npm pack
inrari-npm
.And replace the
@mdn/rari
package in mdn/content locally, which makes the installation with Node.js v22.13 successful.