Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove fx_minversion_note #11187

Closed
7 tasks done
SphinxKnight opened this issue Jan 21, 2023 · 5 comments · Fixed by #11763
Closed
7 tasks done

Chore: remove fx_minversion_note #11187

SphinxKnight opened this issue Jan 21, 2023 · 5 comments · Fixed by #11763
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.

Comments

@SphinxKnight
Copy link
Member

SphinxKnight commented Jan 21, 2023

This macro has been deprecated (cf. mdn/yari@5c0825d#diff-76628de5a1feb6d6ab23c105f6cae6261049b26275183b1d7ccc583faecb6fce)

@SphinxKnight SphinxKnight added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Jan 21, 2023
@SphinxKnight SphinxKnight added this to the Macros removal milestone Jan 21, 2023
@yin1999
Copy link
Member

yin1999 commented Jan 21, 2023

Hi @SphinxKnight, it seems that we still have two left in en-US. I'm not really sure how should we deal with this macro

@SphinxKnight
Copy link
Member Author

Well, we removed Spec2 and SpecName while there is one left in en-US ^^. To me we should dispose of any deprecated macro, regardless their presence in mdn/content (in other words, it doesn't hurt to be in advance for this). Of course, discussion is opened and this issue is merely a tracking issue, each locale may proceed as they see fit and may wait for the removal on the English side first.

@hochan222 hochan222 removed the l10n-ko Issues related to Korean content. label Jan 21, 2023
@yin1999
Copy link
Member

yin1999 commented Jan 22, 2023

poke @mdn/yari-content-web-api for there is two left in content.

@Graywolf9
Copy link
Contributor

Done for es thx to @rwxdan !

@wbamberg
Copy link
Contributor

wbamberg commented Jan 24, 2023

poke @mdn/yari-content-web-api for there is two left in content.

@yin1999 , thanks for letting me know. I filed mdn/content#23854 and mdn/content#23855 for these.

@yin1999 yin1999 removed the l10n-zh Issues related to Chinese content. label Jan 26, 2023
@mfuji09 mfuji09 removed the l10n-ja Issues related to Japanese content. label Feb 2, 2023
@cw118 cw118 removed the l10n-fr Issues related to French content. label Feb 13, 2023
sashasushko added a commit that referenced this issue Feb 20, 2023
* fix(ru): update translation of the Using XMLHttpRequest article
* fix: markdownlint
* Fix #11187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants