Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove {{WebRTCSidebar}} macro from ja #10194

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Remove {{WebRTCSidebar}} macro from ja #10194

merged 1 commit into from
Nov 30, 2022
+2 −2

Conversation

YujiSoftware
Copy link
Contributor

@YujiSoftware YujiSoftware commented Nov 26, 2022 •
edited
Loading

Description

Remove {{WebRTCSidebar}} macro from ja

Related issues and pull requests

Part of #10177

@YujiSoftware YujiSoftware requested a review from a team as a code owner November 26, 2022 09:08
@YujiSoftware YujiSoftware requested review from potappo and removed request for a team November 26, 2022 09:08
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Nov 26, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws (32)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ja/docs/Web/API/WebRTC_API/Connectivity
Title: WebRTC 接続
Flaw count: 32

  • macros:
    • /ja/docs/Glossary/SDP does not exist but fell back to /en-US/docs/Glossary/SDP
    • /ja/docs/Glossary/SDP does not exist but fell back to /en-US/docs/Glossary/SDP
    • /ja/docs/Web/API/Navigator/mediaDevices/getUserMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getUserMedia
    • /ja/docs/Web/API/RTCPeerConnection/addTrack does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/addTrack
    • /ja/docs/Web/API/RTCPeerConnection/createOffer does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/createOffer
    • and 26 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback

wbamberg
wbamberg reviewed Nov 27, 2022
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer on this repo, but the sidebar changes look good to me. Thank you @YujiSoftware !

mfuji09
mfuji09 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。

@mfuji09 mfuji09 merged commit 5c8d42e into mdn:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg left review comments

@mfuji09 mfuji09 mfuji09 approved these changes

@potappo potappo Awaiting requested review from potappo potappo is a code owner automatically assigned from mdn/yari-content-ja

Assignees
No one assigned
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YujiSoftware @wbamberg @mfuji09