-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace {{deprecatedGeneric}} calls with {{deprecated_inline}}; fix all {{deprecated_inline}} calls #11584
Conversation
Preview URLs (45 pages)
Flaws (1683)URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2023-02-12 13:43:24) |
…ge}} into {{Deprecated_Inline}} The `{{DeprecatedGeneric}}` and `{{DeprecatedBadge}}` macros were not used on their own (except accidentally), and `{{deprecated_inline}}` was preferred. This deletes `{{DeprecatedGeneric}}` entirely and merges `{{DeprecatedBadge}}` into `{{deprecated_inline}}`. Depends on mdn/translated-content#11584.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ko
locale. Thank you. Have a nice day!
After running through all the files, it turns out this touches more locales than expected! I'm going to split this up into multiple PRs per each locale. |
This PR replaces the calls to
{{deprecatedGeneric}}
with{{deprecated_inline}}
, following all other pages.{{deprecated_inline}}
is simply a wrapper for{{deprecatedGeneric}}
, but it and{{deprecatedBadge}}
will be merged into{{deprecated_inline}}
soon.Additionally, the behavior of
{{deprecatedGeneric}}
will be going away entirely, so this PR also removes all arguments to the macro calls.