Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted duplicated mdn/content images/assets #4545 #5031

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

yechoi42
Copy link
Member

@yechoi42 yechoi42 commented Apr 8, 2022

#4545 에서 명기된 파일을 모두 삭제하였습니다

@yechoi42 yechoi42 requested a review from a team as a code owner April 8, 2022 15:10
@yechoi42 yechoi42 requested review from yujo11 and removed request for a team April 8, 2022 15:10
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Apr 8, 2022
@yechoi42 yechoi42 added l10n-ko Issues related to Korean content. and removed l10n-ko Issues related to Korean content. labels Apr 8, 2022
@cw118
Copy link
Member

cw118 commented Apr 8, 2022

Hi there, just a quick but important note that these files should stay until mdn/yari#5652 is fixed, otherwise Korean live samples will be broken (cf. French pages which have this problem :/).

The assets fix had worked locally in dev but does not currently work in prod, so please don't merge this before the yari issue is resolved.

@hochan222
Copy link
Member

@cw118 Would it be okay to merge now?

@cw118
Copy link
Member

cw118 commented Jan 30, 2023

@cw118 Would it be okay to merge now?

Hello, as far as I know the issue is unfortunately still not resolved, so if this is merged then Korean live samples that use images from mdn/content will not work (cf. the fr CSS filter page for examples).

@hochan222
Copy link
Member

hochan222 commented Jan 30, 2023

Thank you for your reply. The time for PR has passed quite a bit, so I asked once.

Have a nice day :)

@yin1999
Copy link
Member

yin1999 commented Jul 19, 2023

Hi @hochan222, we can go ahead now. The platform issue has been fixed by mdn/yari#7917. We can now safely remove duplicated images/assets. Please merge main branch and check the related content changes :)

@cw118
Copy link
Member

cw118 commented Jul 19, 2023

@yin1999 just wanted to say thank you so much! It is amazing that we can finally stop duplicating assets from mdn/content 😃

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit 6cea243 into mdn:main Jul 30, 2023
@hochan222 hochan222 mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants