Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update index.html - links images #6864

Merged
merged 8 commits into from
Jul 16, 2022
Merged

Conversation

juanitourquiza
Copy link
Contributor

fix: change links images

fix: change links images
@juanitourquiza juanitourquiza requested a review from a team as a code owner July 14, 2022 17:34
@juanitourquiza juanitourquiza requested review from Vallejoanderson and removed request for a team July 14, 2022 17:34
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Jul 14, 2022
@juanitourquiza juanitourquiza changed the title Update index.html [FIX] Update index.html - links images Jul 14, 2022
@JuanVqz JuanVqz assigned JuanVqz and juanitourquiza and unassigned JuanVqz Jul 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Preview URLs

Flaws

URL: /es/docs/Web/CSS/CSS_Flexible_Box_Layout/Basic_Concepts_of_Flexbox
Title: Conceptos Básicos de flexbox
on GitHub
Flaw count: 15

  • images:
    • Pathname should be relative to document
    • Pathname should be relative to document
    • Pathname should be relative to document
    • Pathname should be relative to document
    • Pathname should be relative to document
    • and 2 more flaws omitted
  • image_widths:
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • 'width' and 'height' set in 'style' attribute on <img> tag.
    • and 2 more flaws omitted
  • translation_differences:
    • Differences in the important macros (7 in common of 11 possible)

External URLs

URL: /es/docs/Web/CSS/CSS_Flexible_Box_Layout/Basic_Concepts_of_Flexbox
Title: Conceptos Básicos de flexbox
on GitHub

No new external URLs

(this comment was updated 2022-07-14 21:07:54.560231)

Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanitourquiza Gracias por contribuir!

No fui capaz de revisar si esto funciona, por que el preview (el link generado por el bot) no muestra las imágenes correctamente pero debería funcionar sin especificar el dominio, esto es para hacer la ruta a las imágenes mas genérica y si en algún futuro ya no se usa developer.mozilla.org como dominio estas imágenes continúen funcionando.

Que opinas?

@juanitourquiza
Copy link
Contributor Author

@JuanVqz de acuerdo ya acepte tu recomendacion

@Jalkhov Jalkhov added the documentation Improvements or additions to documentation label Jul 14, 2022
@JuanVqz JuanVqz merged commit e8c270b into mdn:main Jul 16, 2022
@JuanVqz
Copy link
Member

JuanVqz commented Jul 16, 2022

@juanitourquiza Muchas gracias por tu aportación!

En estos momentos estamos trabajando en poner al día la traducción al Español.

Si deseas seguir apoyando puedes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation l10n-es Issues related to Spanish content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants