Skip to content

Commit

Permalink
fix(a11y): add missing button names (#7733)
Browse files Browse the repository at this point in the history
Improves the Lighthouse accessibility score.
  • Loading branch information
MrBrain295 authored Dec 6, 2022
1 parent cdf1f18 commit 2215c50
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions client/src/document/organisms/sidebar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export function SidebarContainer({ doc, children }) {
extraClasses="backdrop"
type="action"
onClickHandler={() => setIsSidebarOpen(!isSidebarOpen)}
aria-label="Collapse sidebar"
/>
<nav className="sidebar-inner">
<div className="in-nav-toc">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const ArticleActionsContainer = ({
extraClasses="sidebar-button"
icon="sidebar"
type="action"
aria-label="Expand sidebar"
onClickHandler={() => setIsSidebarOpen(!isSidebarOpen)}
/>

Expand Down
1 change: 1 addition & 0 deletions client/src/ui/organisms/article-actions/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export const ArticleActions = ({
>
<Button
type="action"
aria-label="Article actions"
extraClasses="article-actions-toggle"
onClickHandler={toggleArticleActionsMenu}
icon={showArticleActionsMenu ? "cancel" : "ellipses"}
Expand Down

0 comments on commit 2215c50

Please sign in to comment.