fix(sidebar-filter): hide parent container, not parent

Avoids unexpected space caused by parent containers whose containing parent is actually hidden.
mdn · Jun 6, 2023 · 4545c46 · 4545c46
1 parent 06467cc
commit 4545c46
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/client/src/document/organisms/sidebar/SidebarFilterer.ts b/client/src/document/organisms/sidebar/SidebarFilterer.ts
@@ -136,7 +136,8 @@ export class SidebarFilterer {
   }
 
   private collapseParent(el: HTMLDetailsElement) {
-    this.toggleElement(el, false);
+    const container = this.getContainer(el);
+    this.toggleElement(container, false);
     el.dataset.wasOpen = el.dataset.wasOpen ?? String(el.open);
     el.open = false;
   }
@@ -237,7 +238,8 @@ export class SidebarFilterer {
   }
 
   private expandParent(parent: HTMLDetailsElement) {
-    this.toggleElement(parent, true);
+    const container = this.getContainer(parent);
+    this.toggleElement(container, true);
     parent.open = true;
   }