Skip to content

Commit

Permalink
chore(webpack): remove use of appNodeModules
Browse files Browse the repository at this point in the history
use defaults for cache locations
  • Loading branch information
LeoMcA committed May 9, 2024
1 parent 1418f82 commit e84fc2c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
1 change: 0 additions & 1 deletion client/config/paths.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ const config = {
yarnLockFile: resolveApp("../yarn.lock"),
testsSetup: resolveModule(resolveApp, "src/setupTests"),
proxySetup: resolveApp("src/setupProxy.js"),
appNodeModules: resolveApp("../node_modules"),
appWebpackCache: resolveApp("../node_modules/.cache"),
appTsBuildInfoFile: resolveApp("../node_modules/.cache/tsconfig.tsbuildinfo"),
swSrc: resolveModule(resolveApp, "src/service-worker"),
Expand Down
12 changes: 0 additions & 12 deletions client/config/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,6 @@ function config(webpackEnv) {
],
},
resolve: {
// This allows you to set a fallback for where webpack should look for modules.
// We placed these paths second because we want `node_modules` to "win"
// if there are any conflicts. This matches Node resolution mechanism.
// https://github.com/facebook/create-react-app/issues/253
modules: ["node_modules", paths.appNodeModules],
// These are the reasonable defaults supported by the Node ecosystem.
// We also include JSX as a common component filename extension to support
// some tools, although we do not recommend using it, see:
Expand Down Expand Up @@ -570,9 +565,6 @@ function config(webpackEnv) {
new ForkTsCheckerWebpackPlugin({
async: isEnvDevelopment,
typescript: {
typescriptPath: resolve.sync("typescript", {
basedir: paths.appNodeModules,
}),
configOverwrite: {
compilerOptions: {
sourceMap: isEnvProduction
Expand Down Expand Up @@ -619,10 +611,6 @@ function config(webpackEnv) {
failOnError: !(isEnvDevelopment && emitErrorsAsWarnings),
context: paths.appSrc,
cache: true,
cacheLocation: path.resolve(
paths.appNodeModules,
".cache/.eslintcache"
),
// ESLint class options
cwd: paths.appPath,
resolvePluginsRelativeTo: fileURLToPath(
Expand Down

0 comments on commit e84fc2c

Please sign in to comment.