-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's build all en-us docs every 6h instead of 24h #2642
Comments
We could also be more specific. Instead of Whichever we do, we'd need to be more clever about knowing when to include the mdn/translated-content and when not to. For example: if [ date.hour == 1 ];
export CONTENT_TRANSLATED_ROOT=mdn/translated-content/files
fi Ideas welcome. |
@peterbe I really like this idea. I suppose itt adds a wrinkle to how we resolve #2224, in that we'll have to limit the scope of our approach to whatever we're actually building (e.g., only remove docs or redirects in S3 that don't exist within the scope of what we've actually built, for example the English documents). |
Hm … so when switching to non-24h … can we make sure we don't run into Daylight Saving Time shifts somehow?
Would that work out? |
I made an ad-hoc histogram that plots the number of commits on mdn/content per UTC hour:
(this excludes the Dependabot PRs) This is based on only about 3 weeks of PRs. And it's not very conclusive since we've been doing lots of mass-edits for things like flaw cleanups. |
We should avoid the 7am - 7pm UTC at least. |
Sorry, I don't follow. Why should we avoid it? |
Highest number of commits. The cache would stall too often. |
This still sounds like a good idea, what do you think @escattone? |
@schalkneethling I don't think it's worth the effort right now, because of my earlier comment, but I think it's worth considering in the future when there's time to make the changes necessary to the deployer code. |
At the moment, in
prod-build.yml
the cron job runs every 24h. It takes about 50min each time. I believe if you only do mdn/content (aka. only the en-us) it only takes about 15min. The translated-content very rarely changes. It will change once we unfreeze it but even then it might be worth keep that stuff to every 24h.What we could do instead is to build the en-us content every 6h and the whole everything every 24h.
This way, the time between a merged mdn/content PR and getting it into production will be reduced. We still have the CDN cache which might hold on to a page "too long" but if it's a new edit, the chances are better.
The text was updated successfully, but these errors were encountered: