Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The BCD section id is not localized in Baseline Indicator #9848

Open
3 tasks done
yin1999 opened this issue Oct 19, 2023 · 4 comments
Open
3 tasks done

The BCD section id is not localized in Baseline Indicator #9848

yin1999 opened this issue Oct 19, 2023 · 4 comments
Labels
effort: medium This task is a medium effort. idle localization i18n & l10n p2 We want to address this but may have other higher priority items. plus:baseline

Comments

@yin1999
Copy link
Member

yin1999 commented Oct 19, 2023

Summary

The BCD section id should be localized when this is in a l10n document.

Maybe we should also consider localizing all the content of Baseline Indicator.

URL

https://developer.mozilla.org/zh-CN/docs/Web/CSS/grid

Reproduction steps

  1. open the above document
  2. check the "See full compatibility" link

Expected behavior

The link to BCD section should be localized.

Actual behavior

The link to BCD section is not localized.

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

image

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 19, 2023
@caugner caugner added p2 We want to address this but may have other higher priority items. effort: medium This task is a medium effort. plus:baseline localization i18n & l10n and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 19, 2023
@yin1999
Copy link
Member Author

yin1999 commented Oct 19, 2023

Collected localized section ids (not really sure about the ru locale):

const localizedBcdSectionId = {
  "en-US": "browser_compatibility",
  es: "compatibilidad_con_navegadores",
  fr: "compatibilité_des_navigateurs",
  ja: "ブラウザーの互換性",
  ko: "브라우저_호환성",
  "pt-BR": "compatibilidade_de_navegadores",
  ru: "cовместимость_с_браузерами",
  "zh-CN": "浏览器兼容性",
  "zh-TW": "瀏覽器相容性",
};

@LeoMcA
Copy link
Member

LeoMcA commented Dec 4, 2023

Partially fixed with 0761a86 (should deploy to prod tonight)
Unfortunately BCD section IDs aren't consistent within locales - so either that will need to be fixed, or an alternative approach taken for a total fix here.

@yin1999
Copy link
Member Author

yin1999 commented Dec 5, 2023

Thanks @LeoMcA.

/cc @mdn/yari-content-pt-br Is there anyone who could check this. The description here shows that the translation of "Browser compatibility" is inconsistent.

We have both "Compatibilidade com navegadores" and "Compatibilidade de navegadores" in translated content.

@github-actions github-actions bot added the idle label Jan 24, 2024
@yin1999
Copy link
Member Author

yin1999 commented Apr 5, 2024

Hey @LeoMcA. Not sure if we should transfer this issue to mdn/translated-content. I think the rest of the work only needs to be done there :)

@github-actions github-actions bot removed the idle label Apr 5, 2024
@github-actions github-actions bot added the idle label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium This task is a medium effort. idle localization i18n & l10n p2 We want to address this but may have other higher priority items. plus:baseline
Projects
None yet
Development

No branches or pull requests

3 participants