Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fonts): ensure italic looks like italic in Safari #10828

Merged
merged 5 commits into from
May 2, 2024
Merged

fix(fonts): ensure italic looks like italic in Safari #10828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcabe34
Fix: Inter italic bug in Safari
ironnysh Apr 1, 2024
c702557
fix(fonts): apply font-variation-settings to all italic elements
caugner Apr 4, 2024
47cb01d
fix(fonts): unset font-variation-settings where font-style is unset
caugner Apr 4, 2024
d1f29af
fix(fonts): set font-variation-settings: normal where font-style: normal
caugner Apr 4, 2024
c8c7804
revert: do not set font-variation-settings for mathml polyfill
caugner Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/src/about/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
font-family: var(--font-heading);
font-size: 1.313rem;
font-style: normal;
font-variation-settings: normal;
font-weight: normal;
line-height: 175%;
margin: 0;
Expand Down
1 change: 1 addition & 0 deletions client/src/curriculum/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
border-left: 2px solid var(--category-color);
display: inline-block;
font-style: normal;
font-variation-settings: normal;
font-weight: 600;
padding: 0.25rem 0.25rem 0.25rem 0.5rem;
width: 100%;
Expand Down
1 change: 1 addition & 0 deletions client/src/document/ingredients/browser-compatibility-table/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@
.bc-legend-tip {
font-size: var(--type-smaller-font-size);
font-style: italic;
font-variation-settings: "slnt" -10;
margin-bottom: 1rem;
margin-top: 0;
}
Expand Down
1 change: 1 addition & 0 deletions client/src/document/organisms/sidebar/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
border-left: 2px solid var(--category-color);
display: inline-block;
font-style: normal;
font-variation-settings: normal;
font-weight: 600;
hyphens: auto;
padding: 0.25rem;
Expand Down
1 change: 1 addition & 0 deletions client/src/homepage/contributor-spotlight/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
border: 0;
display: flex;
font-style: italic;
font-variation-settings: "slnt" -10;
margin: 0;
padding: 0;

Expand Down
1 change: 1 addition & 0 deletions client/src/minimal-prism.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ don't use any of that, we can safely ignore it.

.token.italic {
font-style: italic;
font-variation-settings: "slnt" -10;
}

.token.entity {
Expand Down
2 changes: 2 additions & 0 deletions client/src/plus/ai-help/landing.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
em {
color: var(--category-color);
font-style: unset;
font-variation-settings: unset;
}
}

Expand Down Expand Up @@ -140,6 +141,7 @@

em {
font-style: unset;
font-variation-settings: unset;
font-weight: 600;
}
}
Expand Down
3 changes: 3 additions & 0 deletions client/src/plus/collections/collection.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
.breadcrumbs {
font-size: 0.6875rem;
font-style: italic;
font-variation-settings: "slnt" -10;
margin-top: -0.5rem;
}

Expand Down Expand Up @@ -98,6 +99,7 @@
font-size: 0.875rem;

font-style: italic;
font-variation-settings: "slnt" -10;
gap: 1rem;
padding: 1rem;

Expand All @@ -118,6 +120,7 @@
&.code {
font-family: var(--font-code);
font-style: normal;
font-variation-settings: normal;
}
}
}
Expand Down
1 change: 1 addition & 0 deletions client/src/plus/common/login-banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
.plus-link {
color: var(--text-primary);
font-style: normal;
font-variation-settings: normal;
text-decoration: underline;
text-decoration-thickness: 0.15rem;
text-underline-offset: 0.1em;
Expand Down
1 change: 1 addition & 0 deletions client/src/plus/icon-card/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
display: flex;
font-size: 0.75rem;
font-style: italic;
font-variation-settings: "slnt" -10;
height: 3rem;
justify-content: center;
padding: 0.5rem;
Expand Down
4 changes: 4 additions & 0 deletions client/src/plus/offer-overview/offer-overview-subscribe/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
color: var(--text-primary);
font-size: 24px;
font-style: normal;
font-variation-settings: normal;
font-weight: 650;
line-height: 120%;
margin-bottom: 2rem;
Expand Down Expand Up @@ -103,6 +104,7 @@
.sub-price {
font-size: 36px;
font-style: normal;
font-variation-settings: normal;
font-weight: 650;
grid-column: 1/2;
justify-self: right;
Expand All @@ -117,6 +119,7 @@
.sub-length {
font-size: 0.8rem;
font-style: normal;
font-variation-settings: normal;
grid-column: 2/3;
justify-self: left;
line-height: 120%;
Expand Down Expand Up @@ -178,6 +181,7 @@
color: var(--text-invert);
font-size: 14px;
font-style: italic;
font-variation-settings: "slnt" -10;
margin-top: auto;
text-decoration: underline;

Expand Down
2 changes: 2 additions & 0 deletions client/src/plus/plus-docs/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
.main-page-content {
em {
font-style: normal;
font-variation-settings: normal;
text-decoration: underline;
text-decoration-color: var(--text-link);
text-decoration-thickness: 0.15rem;
Expand Down Expand Up @@ -40,6 +41,7 @@

p {
font-style: italic;
font-variation-settings: "slnt" -10;
}
}

Expand Down
1 change: 1 addition & 0 deletions client/src/site-search/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

.query-string {
font-style: italic;
font-variation-settings: "slnt" -10;
}

.site-search {
Expand Down
2 changes: 2 additions & 0 deletions client/src/site-search/search-results.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

.highlight {
font-style: italic;
font-variation-settings: "slnt" -10;
}

.nerd-data {
Expand Down Expand Up @@ -83,6 +84,7 @@
border-radius: var(--elem-radius);
color: var(--text-primary);
font-style: italic;
font-variation-settings: "slnt" -10;
}
}

Expand Down
1 change: 1 addition & 0 deletions client/src/ui/base/_prism.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@

.token.italic {
font-style: italic;
font-variation-settings: "slnt" -10;
}

.token.entity {
Expand Down
5 changes: 5 additions & 0 deletions client/src/ui/base/_reset.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ picture {
max-width: 100%;
}

/* Fix Inter font bug: 'em' not slanted in Safari. See issue: https://github.com/mdn/yari/issues/7203 */
em {
font-variation-settings: "slnt" -10;
}

/* Inherit fonts for inputs and buttons */
input,
button,
Expand Down
1 change: 1 addition & 0 deletions client/src/ui/molecules/quote/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ blockquote.quote {
p {
display: flex;
font-style: italic;
font-variation-settings: "slnt" -10;

.icon {
margin-right: 1rem;
Expand Down
1 change: 1 addition & 0 deletions client/src/ui/molecules/search/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@

.nothing-found {
font-style: italic;
font-variation-settings: "slnt" -10;
}

.result-item {
Expand Down
Loading