Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive-examples): grant clipboard-write permission to iframe #10910

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(interactive-examples): grant clipboard-write permission to iframe #10910

merged 2 commits into from
Apr 16, 2024

Conversation

tannerdolby
Copy link
Contributor

@tannerdolby tannerdolby commented Apr 13, 2024

Summary

Fixes #10909

Problem

Copy to clipboard not working in the interactive example <iframe> due to lack of clipboard-write permissions for the Clipboard API

Solution

Enables clipboard-write permission in all of the interactive example iframes to allow Clipboard API use


Screenshots

Before

copy-to-clipboard-iframe-error.mov

After

copy-to-clipboard-iframe-fix.mov

How did you test this change?

Went to the clip-path page locally and used copy-to-clipboard in the interactive example.

@tannerdolby tannerdolby requested a review from a team as a code owner April 13, 2024 09:03
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Apr 13, 2024
@caugner caugner changed the title Fix copy to clipboard in interactive examples fix(interactive-examples): grant clipboard-write permission to iframe Apr 16, 2024
@caugner caugner merged commit fcf94ad into mdn:main Apr 16, 2024
10 checks passed
@tannerdolby tannerdolby deleted the fix-copy-in-iframes branch April 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy to clipboard not working for interactive examples
2 participants