Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground/runner): fix external script loading in playground #11017

Merged
merged 9 commits into from
May 8, 2024
Merged

fix(playground/runner): fix external script loading in playground #11017

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec78a4d
fix(playground/runner): fix external script loading in playground
pseudopilot Apr 27, 2024
9c959ae
refactor mapping
pseudopilot May 3, 2024
859dc15
add comment to make clear
pseudopilot May 3, 2024
0815454
fix code formatting
pseudopilot May 3, 2024
4099a6b
update upproach for handling scripts
pseudopilot May 3, 2024
e387578
Merge branch 'main' into fix-playground-external-script-loading
pseudopilot May 3, 2024
51fa359
code refactoring
pseudopilot May 3, 2024
0ee6700
Merge branch 'main' into fix-playground-external-script-loading
pseudopilot May 3, 2024
dc6de94
Merge branch 'main' into fix-playground-external-script-loading
fiji-flo May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions client/public/runner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
}

let initialized = false;
function init(state) {
async function init(state) {
if (initialized) {
return;
}
Expand All @@ -117,6 +117,13 @@
document.body.innerHTML = "";
setHTML(document.body, state.html);

for (const script of document.querySelectorAll("script[src]")) {
await new Promise((resolve) => {
script.addEventListener("load", () => resolve());
script.addEventListener("error", () => resolve());
});
}

const script = document.createElement("script");
script.textContent = state.js;
document.body.appendChild(script);
Expand All @@ -129,10 +136,10 @@

initialized = true;
}
window.addEventListener("message", (event) => {
window.addEventListener("message", async (event) => {
const e = event.data;
if (e.typ === "init") {
init(e.state);
await init(e.state);
}
if (e.typ === "reload") {
window.location.reload();
Expand Down