feat(cloud-function): setup new Review environment #12694
+262
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller
Unchanged
|
caugner
commented
Mar 3, 2025
There was a problem hiding this comment.
Note: I called this workflow review-deploy to avoid confusion with {prod,stage,test}-build that actually build and deploy content, and to decouple the Cloud Function deployment from the dev-build.
Comment on lines
+23
to
+31
| const { host } = req.headers; | ||
|
|
||
| let actualTarget; | ||
| if (typeof host === "string" && WILDCARD_ENABLED) { | ||
| const subdomain = host.split(".")[0]; | ||
| actualTarget = `${target}${subdomain}/`; | ||
| } else { | ||
| actualTarget = target; | ||
| } |
There was a problem hiding this comment.
Hm, should I add a shortcut:
if (!WILDCARD_ENABLED) {
return target;
}
.github/workflows/dev-build.yml
Outdated
There was a problem hiding this comment.
One could argue that this should be called review-build, because it deploys to $prefix.review.mdn.allizom.net, but since we have rarely used this, let's just keep it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of MP-1889 (Mozilla-internal).
Problem
Our Review environment for content PRs is still hosted in AWS.
Solution
Extend our Cloud Function to support this Review environment, and deploy it to GCP.
How did you test this change?
Tested both locally, and using the deployed Cloud Function.