-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HTMLVersionInline macro #2506
Conversation
At the moment my ideal translation process is a bot that automatically translates and creates a PR on another repository. This thing happens from every repository on every repository. |
@fiji-flo If we merge this, some 200 pages in the translated content, when we uplift all, will get KumaScript rendering flaws on all of these. |
@Elchi3 For the record... |
Would you accept a PR to https://github.com/mdn/translated-content to fix this and then merge this PR to remove the macro? Or are we fine with having flaws in translations? |
If it's a simple I just started an issue to have something for now. |
I propose we leave this as a draft until the translated content has all been uplifted. |
I saw other macros got removed, so ready for review/merge now? |
Still used in a lot of translated content. ...now that they are all kumascript rendered:
We do have a plan to write a flaw checker thing, for translated documents only, that highlights what and how out-of-date a translated document is based on analyzing things that are easy to analyze. For example, the presence of certain macros. The original idea was to pick a couple of KS macros we love and think are important. E.g. |
Okay, closing this until there is something in place to deal with translations. |
I've removed all calls for this macro in mdn/content and the macro isn't called from another macro. In the old world, I would also check translations and remove calls there, but I'm not sure how to do that now.
So, in theory this would be one macro less to worry about but I marked it as a draft because I'd like to hear about the process for translations first. Thanks! ❤️