-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate a _deleted.txt file in CLI #2589
Conversation
CC @escattone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. Bigger question is if we want to use a delete file approach or a "we gather everything and calculate the difference" approach.
"to delete slugs.\n\n"; | ||
} | ||
const url = buildURL(locale, slug); | ||
const newLine = `${url.padEnd(60, " ")} # ${new Date().toDateString()}\n`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const newLine = `${url.padEnd(60, " ")} # ${new Date().toDateString()}\n`; | |
const newLine = `${url.padEnd(60, " ")}\t# ${new Date().toDateString()}\n`; |
can we use a tab here? Easier to split and process.
Yeah, let's hold off on this PR. |
I had the same question as @fiji-flo, so I like that we're holding off for now and sleep on this some more. |
We decided that the Deployer can figure out what should be deleted based on the |
Part of #2224
When you use:
Generates (in
files/en-us/_deleted.txt
):And it works recursively and outside
CONTENT_ROOT
too:Generates (in
files/sv-se/_deleted.txt
):Now, this means we can start reading from this file, in the Deployer, before we proceed to upload stuff. This way, stuff will disappear much sooner from S3 and Elasticsearch.