Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete SpiderMonkeySidebar, SimpleBanner, SimpleBadge, Preferences_Sy… #3061

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Feb 25, 2021

…stem_TOC

Part of #1274

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's not actually used anywhere in the English or non-English content, there's still a reference to SimpleBadge in the English (and Spanish) content here (and here). @chrisdavidmills Can we remove those references?

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Feb 26, 2021

PR opened to fix the English version at least. I don't know if we really care about the es version if it not an active locale?

@peterbe
Copy link
Contributor Author

peterbe commented Feb 26, 2021

Sigh. That means that my tooling for figuring out which ones get rendered isn't working. I'll have to revisit to try to figure out what's going on.

@escattone
Copy link
Contributor

@peterbe No

PR opened to fix the English version at least. I don't know if we really care about the es version if it not an active locale?

Thanks @chrisdavidmills! No, I don't think we care about the es version since it's not active.

@escattone escattone merged commit 3bc7410 into mdn:main Feb 26, 2021
@peterbe peterbe deleted the 1274-delete-spidermonkeysidebar-simplebanner-simplebadge-preferences_system_toc branch February 26, 2021 18:28
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants