Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat tables to include Node for web APIs #3412

Merged
merged 1 commit into from
Apr 1, 2021
Merged

compat tables to include Node for web APIs #3412

merged 1 commit into from
Apr 1, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Apr 1, 2021

Fixes #3410

Yes
Screen Shot 2021-04-01 at 8 25 32 AM

(Still) No
Screen Shot 2021-04-01 at 8 25 18 AM

(Still) Yes
Screen Shot 2021-04-01 at 8 26 32 AM

@peterbe peterbe requested a review from ddbeck April 1, 2021 12:27
ddbeck
ddbeck approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quicker than I would've guessed. Thank you, @peterbe.

@peterbe
Copy link
Contributor Author

peterbe commented Apr 1, 2021

That was quicker than I would've guessed. Thank you, @peterbe.

Me too :)
It was almost too easy. Also, I'm grateful for TypeScript here!

@peterbe peterbe merged commit fd7457d into mdn:main Apr 1, 2021
@peterbe peterbe deleted the 3410-compat-tables-to-include-node-for-web-apis branch April 1, 2021 15:28
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@peterbe
compat tables to include Node for web APIs (mdn#3412)
50ce6db 
Fixes mdn#3410
@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
browser-compat issues related to the browser compatibility data tables (BCD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compat tables should show show Node.js data for Web APIs (where present)
3 participants
@peterbe @ddbeck @caugner