-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deno to browser compat data table #4451
Conversation
This commit adds Deno BCD to the browser compat data table. The "servers" category (Deno and Node.js) is shown if either Node.js or Deno has compat data for a given API.
In terms of the SVG, does this work @lucacasonato? |
@schalkneethling Yeah, that is what I used now. All the other logos are pure black/transparent and less detailed though (the Deno one is very slightly gray if I remember right). Maybe best would just be if I make the image fully black and white. I'll play around with it and see if I can make it look like the other icons. |
@schalkneethling I have opened a PR to add a black icon for Deno to @mdn/dinocons: mdn/mdn-dinocons#37. Figma asset is included too. This PR now links to my GH fork of @mdn/dinocons. This will need to be resolved before the PR can be landed. |
Thank you, this has been merged. I will do a release either today or tomorrow. |
Thanks @schalkneethling! |
Release incoming mdn/mdn-dinocons#40 |
BCD v4.0.0 just dropped, which is the first BCD release to contain Deno data. Looking forward to seeing this PR ship after Yari upgrades! |
Todos have been resolved, PR now ready for review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look great. Great if someone else could test and check it too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ Thanks so much @lucacasonato 🦖
This commit adds Deno BCD to the browser compat data table. The "servers"
category (Deno and Node.js) is shown if either Node.js or Deno has compat data
for a given API.
TODOs:
include this PR: Add platforms/deno icon mdn-dinocons#37
data for Deno.