Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(macros): delete the {{TemplateLink}} macro #7715

Merged
merged 1 commit into from
Dec 15, 2022
Merged

chore(macros): delete the {{TemplateLink}} macro #7715

merged 1 commit into from
Dec 15, 2022

Conversation

MrBrain295
Copy link
Contributor

Summary

Delete the {{TemplateLink}} macro. Waiting on mdn/translated-content#10348

Problem

Its unused.

Solution

Delete it.

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 30, 2022
@MrBrain295 MrBrain295 marked this pull request as draft November 30, 2022 21:21
@MrBrain295 MrBrain295 marked this pull request as ready for review December 1, 2022 03:40
@yin1999
Copy link
Member

yin1999 commented Dec 1, 2022

One more macro used here: https://github.com/mdn/translated-content/pull/10348/files#diff-1604de2bef54c69671801e367526c252e45612200703a7804198c9d6d8ad7562R175

I've resolve this by mdn/translated-content#10028. Let's wait until that PR is settled.

@caugner caugner changed the title Delete the {{TemplateLink}} macro chore(macros): delete the {{TemplateLink}} macro Dec 1, 2022
caugner
caugner reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by mdn/translated-content#10028.

@caugner caugner marked this pull request as draft December 1, 2022 16:57
@yin1999
Copy link
Member

yin1999 commented Dec 15, 2022

{{TemplateLink}} macro has been removed from translated-content. Let's remove it from yari :)

https://github.com/mdn/translated-content/search?q=TemplateLink

@caugner caugner marked this pull request as ready for review December 15, 2022 09:57
@caugner caugner self-requested a review December 15, 2022 09:57
@caugner caugner merged commit 534a925 into mdn:main Dec 15, 2022
@MrBrain295 MrBrain295 deleted the patch-11 branch December 15, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrBrain295 @yin1999 @caugner