enhance(glean): add http_status metric to pings #8420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently only either "200" or "404" merged HydrationData types, and typed pageNotFound property
caugner
requested changes
Mar 14, 2023
caugner
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mozilla-hub.atlassian.net/browse/MP-285
data review (approved): https://bugzilla.mozilla.org/show_bug.cgi?id=1822124
Problem
We can't filter 404s out of our glean data, nor filter just by them to understand what popular 404s are.
Solution
Add a
http_statusmetric for the current page, currently only either "200" or "404"Merged HydrationData types, and typed pageNotFound property. I've put properly typing the other props on my todo list, which I'll do in another PR.
How did you test this change?
Had to test on
:5042, as:3000doesn't SSR and therefore doesn't set theappProps.pageNotFoundproperty.To get glean working on
:5042, either do some git fu to incorporate #8383, or just defineconst CRUD_MODE = true;at the top ofglean-context.tsx.Example ping: https://debug-ping-preview.firebaseapp.com/pings/mdn-dev/d7d33402-2ea4-4b72-b8a2-ef85e2d1dacf#L38