fix(sidebar-filter): avoid duplicate focus events #9106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMcA
added a commit
that referenced
this pull request
Jun 16, 2023
this causes any useEffects depending on it to fire on every render should fix the underlying problem in #9106
|
Closing in favor of #9108. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-482)
Problem
We measure how many users click into the sidebar filter input, but unfortunately each keypress also triggers the event.
Solution
Distinguish the activation change.
How did you test this change?
Added a
console.log()call to theuseEffect()'s inner block to verify it's only called when (re-)activating the sidebar filter.