fix(client): make alt text on images appear in dark mode #9250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the changes! I tried this fix out myself with an image with a wrong src:
Looks good, in my opinion. I don't know if it affects any other places where we have images (pngs?) with a transparent background. It would also be great for Yari dev to have a look, also. |
bsmth
added
ux
caugner
requested changes
Sep 28, 2023
caugner
changed the title
Co-authored-by: Claas Augner <[email protected]>
Done @caugner! :) |
caugner
changed the title
|
@caugner, my PR did not automatically merge. |
caugner
added a commit
that referenced
this pull request
Oct 26, 2023
#9250 caused a regression by changing the background color of all images from white to the default background color, causing issues with images containing black elements on transparent background. This reverts the image background color to white, but sets the text color to the default text color for the dark theme to resolve the original issue with alt texts. Co-authored-by: Claas Augner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9130
Problem
The alt text of images is not visible due to the way the background color is set
Solution
I made set the background color to
transparentfor the dark theme. This will make the alt text appear in dark mode.