Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify additional latex packages #44

Merged
merged 3 commits into from
May 2, 2022

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Apr 9, 2022

Purpose

Adds an optional keyword argument to the XDSM initializer that allows the user to specify additional LaTeX packages they want pyXDSM to use when creating the pdf and tex files of their diagram.

Expected time until merged

Not super urgent, but also not a big PR, max 2 weeks?

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner April 9, 2022 19:01
@A-CGray A-CGray requested a review from marcomangano April 9, 2022 19:01
@marcomangano marcomangano merged commit 3f39ffa into main May 2, 2022
@marcomangano marcomangano deleted the optionalPackages branch May 2, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants