Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying error message #58

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Clarifying error message #58

merged 4 commits into from
Mar 17, 2022

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Mar 16, 2022

Purpose

pyHyp was failing by saying 'There was a boundary condition' when it probably meant 'There was a missing boundary condition' so I added that to the print statements to make it clear that there is an error, not just information.

Expected time until merged

Should be pretty quick

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik requested a review from a team as a code owner March 16, 2022 18:22
@hajdik hajdik requested review from eirikurj and sseraj March 16, 2022 18:22
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #58 (bf26914) into main (bd30793) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files           3        3           
  Lines         363      363           
=======================================
  Hits          277      277           
  Misses         86       86           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@eirikurj eirikurj merged commit 49f4c25 into mdolab:main Mar 17, 2022
@hajdik hajdik deleted the error-wording branch March 17, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants